Mention branch protection ordering #6406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6406 +/- ##
============================================
- Coverage 90.94% 90.91% -0.03%
+ Complexity 6168 6167 -1
============================================
Files 678 678
Lines 18453 18453
Branches 1812 1812
============================================
- Hits 16782 16777 -5
Misses 1140 1140
- Partials 531 536 +5 ☔ View full report in Codecov by Sentry. |
jkwatson
approved these changes
Apr 24, 2024
jack-berg
reviewed
Apr 24, 2024
| The order of branch protection rules | ||
| [can be important](https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/defining-the-mergeability-of-pull-requests/managing-a-branch-protection-rule#about-branch-protection-rules). | ||
| The branch protection rules below should be added before the `**/**` branch protection rule | ||
| (this may require deleting the `**/**` rule and recreating it at the end). |
There was a problem hiding this comment.
Yeah.. super annoying that there isn't a drag-and-drop re-order feature. I have to do awkward things like take a screenshot of a rule, delete it, then re-add it with the config from the screenshot.
jack-berg
approved these changes
May 9, 2024
…y-java into branch-protection-order
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.