Completable result code throwable #6348
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6348 +/- ##
============================================
+ Coverage 91.11% 91.13% +0.01%
- Complexity 5760 5765 +5
============================================
Files 627 627
Lines 16799 16810 +11
Branches 1718 1719 +1
============================================
+ Hits 15306 15319 +13
Misses 998 998
+ Partials 495 493 -2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #6306.
Discussed in the 3/28/24 Java SIG. Also need to adjust the behavior of HttpExporter and GrpcExporter (and potentially the related sender implementations) to fail CompletableResultCodes exceptionally. Planning on doing this in a followup PR, since there are details to work out about what the structure is with the failure exception.