Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency com.google.protobuf:protobuf-bom to v4 #6295

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Mar 13, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
com.google.protobuf:protobuf-bom (source) 3.25.3 -> 4.26.1 age adoption passing confidence

Configuration

πŸ“… Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

β™» Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

πŸ”• Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot requested a review from a team as a code owner March 13, 2024 20:07
@renovate renovate bot force-pushed the renovate/com.google.protobuf-protobuf-bom-4.x branch from 6a82532 to 7133528 Compare March 16, 2024 21:26
@breedx-splk
Copy link
Contributor

I fiddled around with this for a while and couldn't get it working. It looks like the base class of generated messages changes (source?) and it seems like the toByteArray() (at least on grpc Status class) goes away.

@renovate renovate bot force-pushed the renovate/com.google.protobuf-protobuf-bom-4.x branch 2 times, most recently from a1c3c96 to dc7d481 Compare March 29, 2024 15:51
@jack-berg
Copy link
Member

It looks like the base class of generated messages changes (grpc/grpc-java#11015) and it seems like the toByteArray() (at least on grpc Status class) goes away.

The base class for messages changed from GeneratedMessageV3 to GeneratedMessage. The Status class comes from com.google.api.grpc:proto-google-common-protos, which hasn't upgraded to protobuf-bom v4 yet, and so there is a transitive dependency conflict which leads to the missing toByteArray method. We'll need to wait for com.google.api.grpc:proto-google-common-protos to upgrade, or maybe generate the classes ourselves if we're impatient, before upgrading.

Luckily, com.google.protobuf:protobuf-bom is only used in tests.

@renovate renovate bot force-pushed the renovate/com.google.protobuf-protobuf-bom-4.x branch from dc7d481 to 693f6b5 Compare April 13, 2024 18:11
@renovate renovate bot force-pushed the renovate/com.google.protobuf-protobuf-bom-4.x branch from 693f6b5 to 00eaa17 Compare April 18, 2024 14:32
@renovate renovate bot force-pushed the renovate/com.google.protobuf-protobuf-bom-4.x branch 2 times, most recently from 3ebaaa7 to 5435b21 Compare April 29, 2024 15:05
@renovate renovate bot force-pushed the renovate/com.google.protobuf-protobuf-bom-4.x branch from 5435b21 to 6e81e4a Compare May 2, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants