Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory mode: Adding support for synchronous instruments - Last Value aggregation #6196

Conversation

asafm
Copy link
Contributor

@asafm asafm commented Feb 5, 2024

Epic

This is one of many PRs that implement #5105. See the complete plan here.
Specifically, this PR adds the implementation of MemoryMode for the synchronous instrument: counter.

What was done here?

This PR adds support for Memory mode for Last Value Aggregation. It contains:

  • Using a reusable point for returning the result on doAggregateThenMaybeReset for both LongLastValueAggregator.Handle and DoubleLastValueAggregator.Handle.
  • Adding matching garbage collection benchmark tests
  • Adjusting and adding tests for LongLastValueAggregator and DoubleLastValueAggregator

@asafm asafm requested a review from a team as a code owner February 5, 2024 17:34
@asafm
Copy link
Contributor Author

asafm commented Feb 5, 2024

@jack-berg Last aggregator 🎉

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eba8b84) 91.06% compared to head (7dec3a9) 91.04%.
Report is 12 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6196      +/-   ##
============================================
- Coverage     91.06%   91.04%   -0.02%     
- Complexity     5672     5678       +6     
============================================
  Files           620      621       +1     
  Lines         16560    16603      +43     
  Branches       1690     1698       +8     
============================================
+ Hits          15080    15116      +36     
- Misses          993      996       +3     
- Partials        487      491       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jack-berg jack-berg merged commit c12779d into open-telemetry:main Feb 8, 2024
18 checks passed
@asafm asafm deleted the memory-mode-sync-instruments-last-value-aggregation branch February 11, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants