Implement prometheus exporter provider #5053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jack-berg
commented
Dec 19, 2022
| @@ -14,8 +14,6 @@ dependencies { | |||
|
|
|||
| implementation(project(":semconv")) | |||
|
|
|||
| compileOnly(project(":exporters:prometheus")) | |||
There was a problem hiding this comment.
Last exporter compile dependency is gone! Woot!
Codecov ReportBase: 91.17% // Head: 91.21% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #5053 +/- ##
============================================
+ Coverage 91.17% 91.21% +0.04%
- Complexity 4871 4877 +6
============================================
Files 553 553
Lines 14396 14402 +6
Branches 1374 1375 +1
============================================
+ Hits 13125 13137 +12
+ Misses 883 878 -5
+ Partials 388 387 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
jkwatson
reviewed
Dec 20, 2022
...oconfigure/src/main/java/io/opentelemetry/sdk/autoconfigure/MetricExporterConfiguration.java
Outdated
Show resolved
Hide resolved
jkwatson
approved these changes
Dec 21, 2022
mateuszrzeszutek
approved these changes
Dec 21, 2022
...extensions/autoconfigure/src/main/java/io/opentelemetry/sdk/autoconfigure/ClasspathUtil.java
Outdated
Show resolved
Hide resolved
dmarkwat
pushed a commit
to dmarkwat/opentelemetry-java
that referenced
this pull request
Dec 30, 2022
* Implement prometheus exporter provider * Remove stray comment * Adjust method visibility * Delete ClasspathUtil
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #4949.
Prometheus is implemented as a
MetricReaderrather thanMetricExporterso implementingConfigurableMetricExporterProviderisn't an option. This PR takes a different approach and implements theAutoConfigurationCustomizerProvider, which allowsPrometheusCustomizerProviderto customize theSdkMeterProviderBuilderwithPrometheusHttpServerwhenotel.metrics.exporter=prometheus.We could also add a new SPI for providing named
MetricReaders, but we don't actually support custom implementations ofMetricReaderright now so I don't think that's a good idea.