Update semantic and resource attributes for spec v0.15.0 #4938
Conversation
| public static final AttributeKey<String> EXCEPTION_STACKTRACE = stringKey("exception.stacktrace"); | ||
|
|
||
| /** The name identifies the event. */ | ||
| public static final AttributeKey<String> EVENT_NAME = stringKey("event.name"); |
There was a problem hiding this comment.
I'm starting to wonder if maybe we should split the files out by type...i.e. event/span/metric
There was a problem hiding this comment.
Maybe... the counter argument is that attributes may overlap between signals and are expected to have the same semantics. I.e. MetricAttributes.HTTP_METHOD, SpanAttributes.HTTP_METHOD.
There was a problem hiding this comment.
What if we could annotate the attributes with some kind of indication on which signals they should be used with?
There was a problem hiding this comment.
something to think about. I don't want to jump in any direction until things stabilize a bit more, though
Codecov ReportBase: 91.02% // Head: 91.02% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #4938 +/- ##
=========================================
Coverage 91.02% 91.02%
+ Complexity 4840 4839 -1
=========================================
Files 546 546
Lines 14439 14441 +2
Branches 1395 1395
=========================================
+ Hits 13143 13145 +2
Misses 893 893
Partials 403 403
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
semconv/src/main/java/io/opentelemetry/semconv/trace/attributes/SemanticAttributes.java
Outdated
Show resolved
Hide resolved
semconv/src/main/java/io/opentelemetry/semconv/trace/attributes/SemanticAttributes.java
Show resolved
Hide resolved
semconv/src/main/java/io/opentelemetry/semconv/trace/attributes/SemanticAttributes.java
Outdated
Show resolved
Hide resolved
semconv/src/main/java/io/opentelemetry/semconv/trace/attributes/SemanticAttributes.java
Outdated
Show resolved
Hide resolved
|
let's hold off until we can figure out how to get the script to do what we want. |
jkwatson
force-pushed
the
jw/update_015_semconv
branch
from
787ced3
to
72c1b76
Compare
…try#4938) * Update semantic and resource attributes for spec v0.15.0 * explicitly exclude resource attributes * remove more resources, include deprecated tags and attributes
No description provided.