Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds '+' character to allowed characters in baggage value #4898

Merged
merged 7 commits into from Nov 10, 2022
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Expand Up @@ -147,12 +147,21 @@ private static String decodeValue(@Nullable String value) {
return null;
}
try {
return URLDecoder.decode(value, StandardCharsets.UTF_8.name());
return URLDecoder.decode(encodeAllowedCharacters(value), StandardCharsets.UTF_8.name());
} catch (UnsupportedEncodingException e) {
return null;
}
}

/**
* Encodes allowed '+' character into percent, so that URLDecoder won't treat it as a space
* character.
*/
private static String encodeAllowedCharacters(String value) {
value = value.replace("+", "%2B");
return value;
}

/**
* Resets parsing state, preparing to start a new list element (see spec).
*
Expand Down
Expand Up @@ -473,4 +473,34 @@ void inject_nullSetter() {
W3CBaggagePropagator.getInstance().inject(context, carrier, null);
assertThat(carrier).isEmpty();
}

@Test
void shouldAllowBase64SpecialCharacters() {
String encodedInBase64 =
"MngJIFNQIAkhCSIJIwkkCSUJJgknCSgJKQkqCSsJLAktCS4JLwozeAkwCTEJMgkzCTQJNQk2CTcJOAk5CToJOwk8CT0JPgk/CjR4CUAJQQlCCUMJRAlFCUYJRwlICUkJSglLCUwJTQlOCU8KNXgJUAlRCVIJUwlUCVUJVglXCVgJWQlaCVsJXAldCV4JXwo2eAlgCWEJYgljCWQJZQlmCWcJaAlpCWoJawlsCW0JbglvCjd4CXAJcQlyCXMJdAl1CXYJdwl4CXkJegl7CXwJfQl+CQo4eAkJCQkJCQkJCQkJCQkJCQkKOXgJCQkJCQkJCQkJCQkJCQkJCkF4CU5CU1AJwqEJwqIJwqMJwqQJwqUJwqYJwqcJwqgJwqkJwqoJwqsJwqwJU0hZCcKuCcKvCkJ4CcKwCcKxCcKyCcKzCcK0CcK1CcK2CcK3CcK4CcK5CcK6CcK7CcK8CcK9CcK+CcK/CkN4CcOACcOBCcOCCcODCcOECcOFCcOGCcOHCcOICcOJCcOKCcOLCcOMCcONCcOOCcOPCkR4CcOQCcORCcOSCcOTCcOUCcOVCcOWCcOXCcOYCcOZCcOaCcObCcOcCcOdCcOeCcOfCkV4CcOgCcOhCcOiCcOjCcOkCcOlCcOmCcOnCcOoCcOpCcOqCcOrCcOsCcOtCcOuCcOvCkZ4CcOwCcOxCcOyCcOzCcO0CcO1CcO2CcO3CcO4CcO5CcO6CcO7CcO8CcO9CcO+CcO/Cgo=";
jack-berg marked this conversation as resolved.
Show resolved Hide resolved

W3CBaggagePropagator propagator = W3CBaggagePropagator.getInstance();

Context result =
propagator.extract(
Context.root(),
ImmutableMap.of(
"baggage",
"key1= value1; metadata-key = value; othermetadata, "
+ "key2 =value2 , key3 =\tvalue3 , foo="
+ encodedInBase64),
getter);

Baggage expectedBaggage =
Baggage.builder()
.put(
"key1",
"value1",
BaggageEntryMetadata.create("metadata-key = value; othermetadata"))
.put("key2", "value2", BaggageEntryMetadata.empty())
.put("key3", "value3")
.put("foo", encodedInBase64)
.build();
assertThat(Baggage.fromContext(result)).isEqualTo(expectedBaggage);
}
}