Adjustment of behaviour of hasXAttributesSatisfying and hasXAttribute… #4882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sSatisfyingExactly assertions
Codecov ReportBase: 90.90% // Head: 91.06% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #4882 +/- ##
============================================
+ Coverage 90.90% 91.06% +0.16%
- Complexity 4803 4832 +29
============================================
Files 545 545
Lines 14340 14363 +23
Branches 1383 1368 -15
============================================
+ Hits 13036 13080 +44
+ Misses 897 886 -11
+ Partials 407 397 -10
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
@trask I think this was originally your request. Can you review? Thanks! |
sdk/testing/src/main/java/io/opentelemetry/sdk/testing/assertj/AssertUtil.java
Show resolved
Hide resolved
sdk/testing/src/test/java/io/opentelemetry/sdk/testing/assertj/MetricAssertionsTest.java
Outdated
Show resolved
Hide resolved
sdk/testing/src/test/java/io/opentelemetry/sdk/testing/assertj/AssertUtilTest.java
Outdated
Show resolved
Hide resolved
sdk/logs-testing/src/main/java/io/opentelemetry/sdk/testing/assertj/LogRecordDataAssert.java
Outdated
Show resolved
Hide resolved
sdk/testing/src/main/java/io/opentelemetry/sdk/testing/assertj/EventDataAssert.java
Outdated
Show resolved
Hide resolved
sdk/testing/src/test/java/io/opentelemetry/sdk/testing/assertj/MetricAssertionsTest.java
Outdated
Show resolved
Hide resolved
mateuszrzeszutek
approved these changes
Nov 8, 2022
|
How should I update this branch with main? Merge main here, or rebase this one on main and force push? |
|
Merge main branch into this and push please! |
jack-berg
reviewed
Nov 8, 2022
| public final PointAssertT hasAttributesSatisfyingExactly( | ||
| Iterable<AttributeAssertion> assertions) { | ||
| AssertUtil.assertAttributesExactly(actual.getAttributes(), assertions); | ||
| return myself; |
There was a problem hiding this comment.
Can you add coverage for the new code?
There was a problem hiding this comment.
Sure, I'll try to finish this one tomorrow :)
|
Ping @trask 🙂 |
|
sorry for late reply, I'll look at it this week |
trask
approved these changes
Nov 22, 2022
There was a problem hiding this comment.
thx @lmonkiewicz!
comments below are just adding the second (very helpful) sentence across all of the javadocs
sdk/logs-testing/src/main/java/io/opentelemetry/sdk/testing/assertj/LogRecordDataAssert.java
Outdated
Show resolved
Hide resolved
sdk/logs-testing/src/main/java/io/opentelemetry/sdk/testing/assertj/LogRecordDataAssert.java
Outdated
Show resolved
Hide resolved
sdk/testing/src/main/java/io/opentelemetry/sdk/testing/assertj/DoubleExemplarAssert.java
Outdated
Show resolved
Hide resolved
sdk/testing/src/main/java/io/opentelemetry/sdk/testing/assertj/DoubleExemplarAssert.java
Outdated
Show resolved
Hide resolved
sdk/testing/src/main/java/io/opentelemetry/sdk/testing/assertj/EventDataAssert.java
Outdated
Show resolved
Hide resolved
sdk/testing/src/main/java/io/opentelemetry/sdk/testing/assertj/EventDataAssert.java
Outdated
Show resolved
Hide resolved
sdk/testing/src/main/java/io/opentelemetry/sdk/testing/assertj/LongExemplarAssert.java
Outdated
Show resolved
Hide resolved
sdk/testing/src/main/java/io/opentelemetry/sdk/testing/assertj/LongExemplarAssert.java
Outdated
Show resolved
Hide resolved
sdk/testing/src/main/java/io/opentelemetry/sdk/testing/assertj/SpanDataAssert.java
Outdated
Show resolved
Hide resolved
sdk/testing/src/main/java/io/opentelemetry/sdk/testing/assertj/SpanDataAssert.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
dmarkwat
pushed a commit
to dmarkwat/opentelemetry-java
that referenced
this pull request
Dec 30, 2022
open-telemetry#4882) * Adjustment of behaviour of hasXAttributesSatisfying and hasXAttributesSatisfyingExactly assertions * Cleanup * Additional test coverage for new assertion method * Added javadoc on assertions Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com> Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjustment of
hasXAttributesSatisfyingandhasXAttributesSatisfyingExactlyassertions, as described in issueCloses: #4778