Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added info what are the new semantic attributes to be used #4840

Merged
merged 3 commits into from Oct 18, 2022
Merged

Added info what are the new semantic attributes to be used #4840

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dabf207
Added info what are the new semantic attributes to be used
marcingrzejszczak Oct 12, 2022
51a2de8
Regenerated the code
marcingrzejszczak Oct 17, 2022
e9fdb74
Fixed . to #
marcingrzejszczak Oct 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions buildscripts/semantic-convention/templates/SemanticAttributes.java.j2
View file
Open in desktop
Expand Up @@ -166,13 +166,13 @@ public final class {{class}} {
public static final AttributeKey<String> HTTP_HOST = stringKey("http.host");

/**
* @deprecated This item has been removed as of 1.13.0 of the semantic conventions.
* @deprecated This item has been removed as of 1.13.0 of the semantic conventions. Please use {@link SemanticAttributes.NET_SOCK_PEER_ADDR} instead.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jkwatson I briefly brought up the question of how long we retain deprecated semantic attributes here. If we go with one release cycle, then all of these will be deleted and this change is unnecessary.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it's a sticky wicket, isn't it. I don't particularly like that the spec doesn't deprecate but relies on the usage of the schema, which I'm sure no one actually uses. :(

Is there any harm in keeping these around longer?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any harm in keeping these around longer?

AFAIK no, not really. I think we could keep them for a bit longer if it makes it easier for people to migrate off of them; we're certainly no longer using these in the instrumentation repo.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two versions? Three versions?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no idea. Let's raise it as a topic at the Thursday meeting.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added to agenda

*/
@Deprecated
public static final AttributeKey<String> NET_PEER_IP = stringKey("net.peer.ip");

/**
* @deprecated This item has been removed as of 1.13.0 of the semantic conventions.
* @deprecated This item has been removed as of 1.13.0 of the semantic conventions. Please use {@link SemanticAttributes.NET_SOCK_HOST_ADDR} instead.
*/
@Deprecated
public static final AttributeKey<String> NET_HOST_IP = stringKey("net.host.ip");
Expand Down