Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure done before checking success to help troubleshoot timeout issues #4833

Merged
merged 3 commits into from Oct 13, 2022
Merged

Ensure done before checking success to help troubleshoot timeout issues #4833

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f5b8ab2
ensure done before checking success to help troubleshoot timeout issues
breedx-splk Oct 10, 2022
0f89bb5
add done check to testDefaultRetryPolicy method as well.
breedx-splk Oct 11, 2022
f40f0b6
ensure isDone() before other assertions
breedx-splk Oct 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 7 additions & 0 deletions ...autoconfigure/src/testOtlp/java/io/opentelemetry/sdk/autoconfigure/OtlpGrpcRetryTest.java
View file
Open in desktop
Expand Up @@ -120,6 +120,10 @@ private static <T> void testRetryableStatusCodes(

CompletableResultCode resultCode =
exporter.apply(dataSupplier.get()).join(10, TimeUnit.SECONDS);
assertThat(resultCode.isDone())
.as("Exporter didn't complete in time. Consider increasing join timeout?")
.isTrue();
breedx-splk marked this conversation as resolved.
Show resolved Hide resolved

boolean retryable =
RetryUtil.retryableGrpcStatusCodes().contains(String.valueOf(code.value()));
boolean expectedResult = retryable || code == Status.Code.OK;
Expand Down Expand Up @@ -152,6 +156,9 @@ private static <T> void testDefaultRetryPolicy(
// Result should be failure, sever should have received maxAttempts requests
CompletableResultCode resultCode =
exporter.apply(dataSupplier.get()).join(10, TimeUnit.SECONDS);
assertThat(resultCode.isDone())
.as("Exporter didn't complete in time. Consider increasing join timeout?")
.isTrue();
assertThat(resultCode.isSuccess()).isFalse();
assertThat(serverRequestCountSupplier.get()).isEqualTo(maxAttempts);
}
Expand Down
7 changes: 7 additions & 0 deletions ...autoconfigure/src/testOtlp/java/io/opentelemetry/sdk/autoconfigure/OtlpHttpRetryTest.java
View file
Open in desktop
Expand Up @@ -129,6 +129,10 @@ private static <T> void testRetryableStatusCodes(

CompletableResultCode resultCode =
exporter.apply(dataSupplier.get()).join(10, TimeUnit.SECONDS);
assertThat(resultCode.isDone())
.as("Exporter didn't complete in time. Consider increasing join timeout?")
.isTrue();

boolean retryable = code != 200 && RetryUtil.retryableHttpResponseCodes().contains(code);
boolean expectedResult = retryable || code == 200;
assertThat(resultCode.isSuccess())
Expand Down Expand Up @@ -159,6 +163,9 @@ private static <T> void testDefaultRetryPolicy(
// Result should be failure, sever should have received maxAttempts requests
CompletableResultCode resultCode =
exporter.apply(dataSupplier.get()).join(10, TimeUnit.SECONDS);
assertThat(resultCode.isDone())
.as("Exporter didn't complete in time. Consider increasing join timeout?")
.isTrue();
assertThat(resultCode.isSuccess()).isFalse();
assertThat(serverRequestCountSupplier.get()).isEqualTo(maxAttempts);
}
Expand Down