Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add event API #4781

Merged
merged 2 commits into from
Sep 27, 2022
Merged

Add event API #4781

merged 2 commits into from
Sep 27, 2022

Conversation

jack-berg
Copy link
Member

Resolves #4714.

@jack-berg jack-berg requested a review from a team as a code owner September 26, 2022 18:46
@codecov
Copy link

codecov bot commented Sep 26, 2022

Codecov Report

Base: 90.78% // Head: 90.76% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (5301ae5) compared to base (a1cf20d).
Patch coverage: 92.10% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4781      +/-   ##
============================================
- Coverage     90.78%   90.76%   -0.03%     
- Complexity     4822     4835      +13     
============================================
  Files           554      554              
  Lines         14383    14414      +31     
  Branches       1397     1399       +2     
============================================
+ Hits          13058    13083      +25     
- Misses          909      911       +2     
- Partials        416      420       +4     
Impacted Files Coverage Δ
...java/io/opentelemetry/api/logs/LoggerProvider.java 100.00% <ø> (ø)
...io/opentelemetry/sdk/logs/SdkLogRecordBuilder.java 97.36% <ø> (ø)
.../opentelemetry/api/logs/DefaultLoggerProvider.java 91.66% <87.50%> (-8.34%) ⬇️
...main/java/io/opentelemetry/sdk/logs/SdkLogger.java 90.00% <87.50%> (-10.00%) ⬇️
.../java/io/opentelemetry/api/logs/DefaultLogger.java 100.00% <100.00%> (ø)
...va/io/opentelemetry/sdk/logs/SdkLoggerBuilder.java 100.00% <100.00%> (ø)
...metry/sdk/metrics/export/PeriodicMetricReader.java 87.14% <0.00%> (-2.86%) ⬇️
...metry/sdk/logs/export/BatchLogRecordProcessor.java 88.97% <0.00%> (-0.74%) ⬇️
...opentelemetry/opentracingshim/SpanBuilderShim.java 77.89% <0.00%> (ø)
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@jkwatson jkwatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% convinced that this API will end up being particularly user-friendly, but I'd like to get it into the project and try it out and see how it feels when used "in anger" before I pass final judgement on it.

@jack-berg
Copy link
Member Author

I'm not 100% convinced that this API will end up being particularly user-friendly

We'll see how it goes! I'm not particularly fond of having to use a bunch of Logger* classes to emit events. Maybe we can alleviate confusion through good documentation, maybe not. I hope this prototype produces the type of feedback we need to improve our comfort with this design, or change course.

@jack-berg jack-berg merged commit 01a07b5 into open-telemetry:main Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement log appender / event api
3 participants