Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decode resource attributes specified via otel.resource.attributes #4756

Merged
merged 1 commit into from Oct 18, 2022

Conversation

jack-berg
Copy link
Member

Resolves #4653.

@codecov
Copy link

codecov bot commented Sep 13, 2022

Codecov Report

Base: 90.77% // Head: 90.76% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (8fabd02) compared to base (cdab465).
Patch coverage: 77.77% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4756      +/-   ##
============================================
- Coverage     90.77%   90.76%   -0.01%     
- Complexity     4814     4815       +1     
============================================
  Files           551      551              
  Lines         14356    14363       +7     
  Branches       1395     1396       +1     
============================================
+ Hits          13031    13037       +6     
- Misses          909      911       +2     
+ Partials        416      415       -1     
Impacted Files Coverage Δ
.../api/baggage/propagation/W3CBaggagePropagator.java 81.63% <ø> (ø)
...metry/sdk/autoconfigure/ResourceConfiguration.java 94.87% <75.00%> (-5.13%) ⬇️
.../io/opentelemetry/api/internal/PercentEscaper.java 84.21% <100.00%> (ø)
...entelemetry/sdk/logs/export/BatchLogProcessor.java 89.47% <0.00%> (+0.75%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Sep 28, 2022
@jack-berg jack-berg removed the Stale label Sep 28, 2022
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Oct 12, 2022
@jack-berg jack-berg removed the Stale label Oct 12, 2022
@jack-berg
Copy link
Member Author

@jkwatson please take a look when you have a chance

@jack-berg jack-berg merged commit db1d065 into open-telemetry:main Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decode values from OTEL_RESOURCE_ATTRIBUTES
3 participants