Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement aws.ecs.* resource attributes #4670

Closed

Conversation

mmanciop
Copy link
Contributor

@mmanciop mmanciop commented Aug 5, 2022

Add to io.opentelemetry.sdk.extension.aws.resource.EcsResource the logic to detect the aws.ecs.* resource attributes using data from the Amazon ECS Metadata v4 endpoint.

Add to io.opentelemetry.sdk.extension.aws.resource.EcsResource the logic to detect the aws.ecs resource attributes from the Amazon ECS Metadata v4 endpoint.
@mmanciop mmanciop requested a review from a user August 5, 2022 13:30
@mmanciop mmanciop requested a review from Oberon00 as a code owner August 5, 2022 13:30
@codecov
Copy link

codecov bot commented Aug 5, 2022

Codecov Report

Merging #4670 (360c5d8) into main (4bfe17f) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #4670      +/-   ##
============================================
- Coverage     90.13%   90.12%   -0.02%     
  Complexity     5069     5069              
============================================
  Files           584      584              
  Lines         15649    15649              
  Branches       1503     1503              
============================================
- Hits          14106    14103       -3     
- Misses         1091     1092       +1     
- Partials        452      454       +2     
Impacted Files Coverage Δ
...metry/sdk/metrics/export/PeriodicMetricReader.java 87.14% <0.00%> (-2.86%) ⬇️
...entelemetry/sdk/logs/export/BatchLogProcessor.java 88.72% <0.00%> (-0.76%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@trask
Copy link
Member

trask commented Aug 5, 2022

@jeromeinsf could you help us find someone from AWS that could review this PR?

@jkwatson
Copy link
Contributor

jkwatson commented Aug 5, 2022

@willarmiros Can you review this?

@willarmiros
Copy link

Correct me if I'm wrong, but this appears to be a subset of #4574. I believe the other PR adds all of the attributes added by this one and more? If so, would you be amenable to closing this PR as a duplicate of #4574 @mmanciop?

@mmanciop
Copy link
Contributor Author

mmanciop commented Aug 9, 2022

@willarmiros #4574 does not implement AWS_ECS_LAUNCHTYPE but for the rest yes, it is a superset and I'd be OK closing mine as duplicate

@mmanciop mmanciop closed this Aug 9, 2022
@mmanciop mmanciop deleted the aws-ecs-resource-attributes branch August 9, 2022 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants