Add option in BatchSpanProcessor to support multiple pending exports #4280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
requested review from
anuraaga,
jack-berg,
jkwatson and
jsuereth
as code owners
Codecov Report
@@ Coverage Diff @@
## main #4280 +/- ##
=========================================
Coverage 89.88% 89.88%
- Complexity 4844 4847 +3
=========================================
Files 568 568
Lines 15063 15081 +18
Branches 1427 1429 +2
=========================================
+ Hits 13539 13556 +17
Misses 1060 1060
- Partials 464 465 +1
Continue to review full report at Codecov.
|
ghost
approved these changes
Mar 21, 2022
sdk/trace/src/main/java/io/opentelemetry/sdk/trace/export/BatchSpanProcessor.java
Show resolved
Hide resolved
trask
commented
Mar 22, 2022
sdk/trace/src/main/java/io/opentelemetry/sdk/trace/export/BatchSpanProcessor.java
Outdated
Show resolved
Hide resolved
|
discussed with @anuraaga, I'm not in a rush for this change, will open a spec issue to discuss adding this setting to the spec |
trask
changed the title
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
@open-telemetry/java-maintainers can you apply the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4264
This is a third option that I like better than both #4245 and #4246.