Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement log appender / event api #4714

Closed
7 tasks done
jack-berg opened this issue Aug 22, 2022 · 0 comments · Fixed by #4781
Closed
7 tasks done

Implement log appender / event api #4714

jack-berg opened this issue Aug 22, 2022 · 0 comments · Fixed by #4781
Labels
Feature Request Suggest an idea for this project

Comments

@jack-berg
Copy link
Member

jack-berg commented Aug 22, 2022

The spec is going to soon have a log appender / event API, in addition to the existing SDK.

To implement we need:

  • Rename classes for alignment. We have LogEmitterProvider and LogEmitter right now, we're going to need LoggerProvider and Logger. The rename is going to sting quite a bit because stable artifacts like OpenTelemetrySdk have references to the old names. We justified this because although OpenTelemetrySdk is stable, you need to take a dependency on the log SDK in order to use the log portions of the API. We'll need to make one time exception rules for jApiCmp to pass. Change LogEmitter to Logger, LogEmitterProvider to LoggerProvider #4721
  • Break out :api:logs module, including interfaces like LoggerProvider, Logger, LogRecordBuilder, etc. Split out logs API #4764
  • Add GlobalLoggerProvider akin to the old GlobalMeterProvider, which will hold global reference while until log stability is reached and it can merge with GlobalOpenTelemetry. Split out logs API #4764
  • Extend API for events. Logger should have a logRecordBuilder() for use by log appenders, and eventBuilder(String name) for events.
  • Rename LogProcessor, *LogProcessor to LogRecordProcessor, *LogRecordProcessor. Rename LogProcessor to LogRecordProcessor #4772
  • Rename LogExporter, *LogExporter to LogRecordExporter, *LogRecordExporter. Rename LogExporter to LogRecordExporter #4773
  • Rename LogData to LogRecordData. Rename LogData to LogRecordData #4774

When this is complete the instrumentation repo will be able to delete instrumentation-appender-api-internal and instrumentation-appender-sdk-internal 🎉.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Suggest an idea for this project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant