Encode enums as numbers in logging OTLP exporters (#4783)

open-telemetry · Oct 17, 2022 · 5be58c5 · 5be58c5
1 parent 250a2f0
commit 5be58c5
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 9 deletions.
diff --git a/...rters/common/src/main/java/io/opentelemetry/exporter/internal/marshal/JsonSerializer.java b/...rters/common/src/main/java/io/opentelemetry/exporter/internal/marshal/JsonSerializer.java
@@ -43,7 +43,7 @@ public void writeBool(ProtoFieldInfo field, boolean value) throws IOException {
 
   @Override
   protected void writeEnum(ProtoFieldInfo field, ProtoEnumInfo enumValue) throws IOException {
-    generator.writeStringField(field.getJsonName(), enumValue.getJsonName());
+    generator.writeNumberField(field.getJsonName(), enumValue.getEnumNumber());
   }
 
   @Override

diff --git a/...est/java/io/opentelemetry/exporter/logging/otlp/OtlpJsonLoggingLogRecordExporterTest.java b/...est/java/io/opentelemetry/exporter/logging/otlp/OtlpJsonLoggingLogRecordExporterTest.java
@@ -110,7 +110,7 @@ void log() throws Exception {
             + "     },"
             + "     \"logRecords\": [{"
             + "       \"timeUnixNano\":\"1631533710000000\","
-            + "       \"severityNumber\":\"SEVERITY_NUMBER_INFO\","
+            + "       \"severityNumber\":9,"
             + "       \"severityText\":\"INFO\","
             + "       \"body\": {"
             + "         \"stringValue\":\"body2\""
@@ -137,7 +137,7 @@ void log() throws Exception {
             + "     },"
             + "     \"logRecords\": [{"
             + "       \"timeUnixNano\":\"1631533710000000\","
-            + "       \"severityNumber\":\"SEVERITY_NUMBER_INFO\","
+            + "       \"severityNumber\":9,"
             + "       \"severityText\":\"INFO\","
             + "       \"body\": {"
             + "         \"stringValue\":\"body1\""

diff --git a/...c/test/java/io/opentelemetry/exporter/logging/otlp/OtlpJsonLoggingMetricExporterTest.java b/...c/test/java/io/opentelemetry/exporter/logging/otlp/OtlpJsonLoggingMetricExporterTest.java
@@ -122,7 +122,7 @@ void log() throws Exception {
             + "          \"timeUnixNano\": \"2\","
             + "          \"asDouble\": 4.0"
             + "        }],"
-            + "        \"aggregationTemporality\": \"AGGREGATION_TEMPORALITY_CUMULATIVE\","
+            + "        \"aggregationTemporality\": 2,"
             + "        \"isMonotonic\": true"
             + "      }"
             + "    }]"
@@ -151,7 +151,7 @@ void log() throws Exception {
             + "          \"timeUnixNano\": \"2\","
             + "          \"asDouble\": 4.0"
             + "        }],"
-            + "        \"aggregationTemporality\": \"AGGREGATION_TEMPORALITY_CUMULATIVE\","
+            + "        \"aggregationTemporality\": 2,"
             + "        \"isMonotonic\": true"
             + "      }"
             + "    }]"

diff --git a/...src/test/java/io/opentelemetry/exporter/logging/otlp/OtlpJsonLoggingSpanExporterTest.java b/...src/test/java/io/opentelemetry/exporter/logging/otlp/OtlpJsonLoggingSpanExporterTest.java
@@ -126,11 +126,11 @@ void log() throws Exception {
             + "      \"traceId\": \"12340000000043211234000000004321\","
             + "      \"spanId\": \"8765000000005678\","
             + "      \"name\": \"testSpan2\","
-            + "      \"kind\": \"SPAN_KIND_CLIENT\","
+            + "      \"kind\": 3,"
             + "      \"startTimeUnixNano\": \"500\","
             + "      \"endTimeUnixNano\": \"1501\","
             + "      \"status\": {"
-            + "        \"code\": \"STATUS_CODE_ERROR\""
+            + "        \"code\": 2"
             + "      }"
             + "    }]"
             + "  }, {"
@@ -148,7 +148,7 @@ void log() throws Exception {
             + "      \"traceId\": \"12345678876543211234567887654321\","
             + "      \"spanId\": \"8765432112345678\","
             + "      \"name\": \"testSpan1\","
-            + "      \"kind\": \"SPAN_KIND_INTERNAL\","
+            + "      \"kind\": 1,"
             + "      \"startTimeUnixNano\": \"100\","
             + "      \"endTimeUnixNano\": \"1100\","
             + "      \"attributes\": [{"
@@ -173,7 +173,7 @@ void log() throws Exception {
             + "        }]"
             + "      }],"
             + "      \"status\": {"
-            + "        \"code\": \"STATUS_CODE_OK\""
+            + "        \"code\": 1"
             + "      }"
             + "    }]"
             + "  }]"