Ensure done before checking success to help troubleshoot timeout issu…

…es (#4833) * ensure done before checking success to help troubleshoot timeout issues * add done check to testDefaultRetryPolicy method as well. * ensure isDone() before other assertions
open-telemetry · Oct 13, 2022 · 3f4698a · 3f4698a
1 parent d83d2d8
commit 3f4698a
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/...autoconfigure/src/testOtlp/java/io/opentelemetry/sdk/autoconfigure/OtlpGrpcRetryTest.java b/...autoconfigure/src/testOtlp/java/io/opentelemetry/sdk/autoconfigure/OtlpGrpcRetryTest.java
@@ -120,6 +120,10 @@ private static <T> void testRetryableStatusCodes(
 
       CompletableResultCode resultCode =
           exporter.apply(dataSupplier.get()).join(10, TimeUnit.SECONDS);
+      assertThat(resultCode.isDone())
+          .as("Exporter didn't complete in time. Consider increasing join timeout?")
+          .isTrue();
+
       boolean retryable =
           RetryUtil.retryableGrpcStatusCodes().contains(String.valueOf(code.value()));
       boolean expectedResult = retryable || code == Status.Code.OK;
@@ -152,6 +156,9 @@ private static <T> void testDefaultRetryPolicy(
     // Result should be failure, sever should have received maxAttempts requests
     CompletableResultCode resultCode =
         exporter.apply(dataSupplier.get()).join(10, TimeUnit.SECONDS);
+    assertThat(resultCode.isDone())
+        .as("Exporter didn't complete in time. Consider increasing join timeout?")
+        .isTrue();
     assertThat(resultCode.isSuccess()).isFalse();
     assertThat(serverRequestCountSupplier.get()).isEqualTo(maxAttempts);
   }

diff --git a/...autoconfigure/src/testOtlp/java/io/opentelemetry/sdk/autoconfigure/OtlpHttpRetryTest.java b/...autoconfigure/src/testOtlp/java/io/opentelemetry/sdk/autoconfigure/OtlpHttpRetryTest.java
@@ -129,6 +129,10 @@ private static <T> void testRetryableStatusCodes(
 
       CompletableResultCode resultCode =
           exporter.apply(dataSupplier.get()).join(10, TimeUnit.SECONDS);
+      assertThat(resultCode.isDone())
+          .as("Exporter didn't complete in time. Consider increasing join timeout?")
+          .isTrue();
+
       boolean retryable = code != 200 && RetryUtil.retryableHttpResponseCodes().contains(code);
       boolean expectedResult = retryable || code == 200;
       assertThat(resultCode.isSuccess())
@@ -159,6 +163,9 @@ private static <T> void testDefaultRetryPolicy(
     // Result should be failure, sever should have received maxAttempts requests
     CompletableResultCode resultCode =
         exporter.apply(dataSupplier.get()).join(10, TimeUnit.SECONDS);
+    assertThat(resultCode.isDone())
+        .as("Exporter didn't complete in time. Consider increasing join timeout?")
+        .isTrue();
     assertThat(resultCode.isSuccess()).isFalse();
     assertThat(serverRequestCountSupplier.get()).isEqualTo(maxAttempts);
   }