Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gradle to 7.5.1 #6359

Merged

Conversation

mateuszrzeszutek
Copy link
Member

No description provided.

@mateuszrzeszutek mateuszrzeszutek requested a review from a team as a code owner July 21, 2022 14:05
@trask trask changed the title Update gradle to 7.5 Update gradle to 7.5.1 Aug 6, 2022
@trask
Copy link
Member

trask commented Aug 6, 2022

fyi I bumped this to 7.5.1 just to see if that helped, but same error still

@laurit
Copy link
Contributor

laurit commented Aug 7, 2022

mateuszrzeszutek#47 adds the --add-opens needed to get the tests passing. Alternatively I guess we could add these to org.gradle.jvmargs.

@mateuszrzeszutek
Copy link
Member Author

@laurit WDYT about adding these JVM args to the otel.java-conventions gradle script instead? Could save us a lot of copy-paste

@laurit
Copy link
Contributor

laurit commented Aug 9, 2022

@mateuszrzeszutek that is definitely an option. A potential benefit of not doing it would be that this could mask bugs in agent that cause it to fail without these arguments, but that doesn't seem like a big issue as we also have smoke tests that would take care of catching such issues.

@trask
Copy link
Member

trask commented Aug 11, 2022

@laurit any idea why this only started to be a problem in gradle 7.5?

@laurit
Copy link
Contributor

laurit commented Aug 11, 2022

@laurit any idea why this only started to be a problem in gradle 7.5?

@trask gradle used to add

--add-opens
java.base/java.util=ALL-UNNAMED
--add-opens
java.base/java.lang=ALL-UNNAMED

by default, see gradle/gradle#19771

Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like keeping the --add-opens scoped to the instrumented library that needs them 👍

@mateuszrzeszutek
Copy link
Member Author

I like keeping the --add-opens scoped to the instrumented library that needs them 👍

Gotcha. I'm merging this PR then, since I'm fine with both solutions.
Thanks for help with this @laurit !

@mateuszrzeszutek mateuszrzeszutek merged commit 08f013f into open-telemetry:main Aug 12, 2022
@mateuszrzeszutek mateuszrzeszutek deleted the update-gradle-version branch August 12, 2022 10:03
LironKS pushed a commit to helios/opentelemetry-java-instrumentation that referenced this pull request Oct 23, 2022
* Update gradle to 7.5

* Bump to 7.5.1

* gradle 7.5.1 with jdk17

* spotless

* one more --add-opens

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Co-authored-by: Lauri Tulmin <ltulmin@splunk.com>
LironKS pushed a commit to helios/opentelemetry-java-instrumentation that referenced this pull request Oct 31, 2022
* Update gradle to 7.5

* Bump to 7.5.1

* gradle 7.5.1 with jdk17

* spotless

* one more --add-opens

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Co-authored-by: Lauri Tulmin <ltulmin@splunk.com>
LironKS pushed a commit to helios/opentelemetry-java-instrumentation that referenced this pull request Dec 4, 2022
* Update gradle to 7.5

* Bump to 7.5.1

* gradle 7.5.1 with jdk17

* spotless

* one more --add-opens

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Co-authored-by: Lauri Tulmin <ltulmin@splunk.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants