Make it possible to configure base time unit used by the Micrometer bridge #5304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuraaga
reviewed
Feb 4, 2022
| tasks { | ||
| val testBaseTimeUnit by registering(Test::class) { | ||
| filter { | ||
| includeTestsMatching("*TimerSecondsTest") |
There was a problem hiding this comment.
JFYI I have been interested in changing the javaVersion type of tests from calling test to calling check - I think check.dependsOn(otherTest) is a bit more idiomatic than test.dependsOn and avoids this annoying non-trivial boiler plate every time.
anuraaga
approved these changes
Feb 4, 2022
trask
approved these changes
Feb 8, 2022
Comment on lines
+34
to
+38
| case "min": | ||
| case "minutes": |
There was a problem hiding this comment.
are these names and abbreviations from micrometer/otel/ucum?
There was a problem hiding this comment.
Shorter names come from UCUM, the longer ones are just TimeUnit values lowercased - I thought it would be quite useful to have both
...java/io/opentelemetry/instrumentation/micrometer/v1_5/OpenTelemetryMeterRegistryBuilder.java
Show resolved
Hide resolved
mateuszrzeszutek
force-pushed
the
micrometer-base-time-unit
branch
from
20fc5f1
to
265ce99
Compare
RashmiRam
pushed a commit
to RashmiRam/opentelemetry-auto-instr-java
that referenced
this pull request
May 23, 2022
…ridge (open-telemetry#5304) * Make it possible to configure base time unit used by the Micrometer bridge * add readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another one inspired by #5292