feat(spring-mvc): Fallback to name Span including requestURI #10951
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
opentelemetry-spring-boot-starter
defaults to create an instance ofWebMvcTelemetryProducingFilter
for Spring WebMvc Applications . This filter applies to all requests.However, you only get "beautiful span names" for mappings of type
RequestMappingHandlerMapping
. I understand this is most likely related to the desire to group path patterns under a common span name.For other, non
RequestMappingHandlerMapping
based requests, you get the bare HTTP method - e.g.GET
for the span name.Sure, the name
WebMvc
hints at Spring WebMvc, but the filter creates spans already. Besides, the code around it already does most of the wiring you want in more bare situations (e.g. Servlet).Wouldn't it be reasonable to fallback to
requestURI
based paths, so we getGET /not-request-mapping-handler-mapping
instead ofGET
span names when the request is notRequestMappingHandlerMapping
based?The attached patch does the trick for me.