[collector] provide support for windows

[povilasv]

Allow users to set isWindows flag to true, which will configure mounts and various presets to use windows paths.

This change will also add a new node selector for all existing users:

      nodeSelector:
        kubernetes.io/os: linux

AFAIK this shouldn't be breaking change?

Added example with windows:

• https://github.com/open-telemetry/opentelemetry-helm-charts/pull/792/files#diff-903e8d385e1abafd5f68d83210069f94ee41ed1fd832db2523356f4633b067aaR31

[TylerHelmuth]

I'm concerned that we don't have a good way to test this setting since all our CI runs on linux. Were you able to test locally?

[TylerHelmuth]

I'm concerned that we don't have a good way to test this setting since all our CI runs on linux. Were you able to test locally?

[dmitryax]

This is still needed for windows, just under different path, right?

[povilasv]

When I tried to set path I got this error -> https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/4697200b4ea01a96f5d737d6836dc5ee4b0a6a7b/receiver/hostmetricsreceiver/hostmetrics_others.go#L14

Not sure how it works on windows, but it seems we don’t

[povilasv]

I'm concerned that we don't have a good way to test this setting since all our CI runs on linux. Were you able to test locally?

I am testing this in Amazon EKS with Windows nodes together with Linux ones :)

Colleague is also looking to contribute the Docker images in open-telemetry/opentelemetry-collector-releases#339

Really valid concerns. Not sure how feasible is this to do some testing with ci as might be complicated to spin up windows. But can look into this.

[github-actions]

This PR was marked stale due to lack of activity. It will be closed in 14 days.

[povilasv]

I've looked at ability to run windows in CI and couldn't find anything that runs out of the box. Maybe this tool could be adapated https://github.com/kubernetes-sigs/sig-windows-dev-tools but it would probably quite a lot of effort.

So closing for now.