Merge Span.AddLink tests #5115
Merged
Merge Span.AddLink tests #5115
+98
−126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: perhapsmaple <140232061+perhapsmaple@users.noreply.github.com>
perhapsmaple
requested review from
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
|
I wonder if |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5115 +/- ##
=======================================
- Coverage 84.5% 84.5% -0.1%
=======================================
Files 267 267
Lines 17563 17563
=======================================
- Hits 14844 14842 -2
- Misses 2407 2409 +2
Partials 312 312 |
Signed-off-by: perhapsmaple <140232061+perhapsmaple@users.noreply.github.com>
|
Hi @dmathieu, I have added |
XSAM
requested changes
Apr 1, 2024
XSAM
reviewed
Apr 1, 2024
dmathieu
requested changes
Apr 2, 2024
Co-authored-by: Sam Xie <sam@samxie.me>
Co-authored-by: Sam Xie <sam@samxie.me>
Signed-off-by: perhapsmaple <140232061+perhapsmaple@users.noreply.github.com>
dmathieu
reviewed
Apr 3, 2024
Signed-off-by: perhapsmaple <140232061+perhapsmaple@users.noreply.github.com>
dmathieu
approved these changes
Apr 4, 2024
pellared
approved these changes
Apr 4, 2024
XSAM
reviewed
Apr 5, 2024
Co-authored-by: Sam Xie <sam@samxie.me>
Signed-off-by: perhapsmaple <140232061+perhapsmaple@users.noreply.github.com>
XSAM
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5114
Refactored Span.AddLink tests into a single test