Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial Logs Bridge API scaffolding #4907

Merged
merged 7 commits into from
Feb 16, 2024

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Feb 12, 2024

Part of #3827

Add the initial scaffolding the logs bridge API will be built from. This is a copy of all the things discussed in the logs design doc. All implementation details have been omitted and documented with "TODO"s that link to the issue tracking the work.

Blocks:

@MrAlias MrAlias added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Feb 12, 2024
Copy link

codecov bot commented Feb 12, 2024

Codecov Report

Attention: 58 lines in your changes are missing coverage. Please review.

Comparison is base (02b6123) 82.7% compared to head (7411393) 82.4%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #4907     +/-   ##
=======================================
- Coverage   82.7%   82.4%   -0.3%     
=======================================
  Files        232     237      +5     
  Lines      18916   18974     +58     
=======================================
+ Hits       15649   15651      +2     
- Misses      2977    3033     +56     
  Partials     290     290             
Files Coverage Δ
log/logger.go 0.0% <0.0%> (ø)
log/kind_string.go 0.0% <0.0%> (ø)
log/severity_string.go 0.0% <0.0%> (ø)
log/record.go 0.0% <0.0%> (ø)
log/keyvalue.go 0.0% <0.0%> (ø)

... and 1 file with indirect coverage changes

@MrAlias MrAlias force-pushed the log-bridge-api-scaffold branch 2 times, most recently from 8c5a496 to 9c0a533 Compare February 12, 2024 21:01
@MrAlias MrAlias mentioned this pull request Feb 9, 2024
11 tasks
@MrAlias MrAlias marked this pull request as ready for review February 12, 2024 21:44
@MrAlias MrAlias added the area:logs Part of OpenTelemetry logs label Feb 12, 2024
Copy link
Contributor

@dashpole dashpole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm after question is resolved

Copy link
Member

@XSAM XSAM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@MrAlias MrAlias merged commit d3dcb39 into open-telemetry:main Feb 16, 2024
29 of 30 checks passed
@MrAlias MrAlias deleted the log-bridge-api-scaffold branch February 16, 2024 15:10
@MrAlias MrAlias added this to the v1.24.0 milestone Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:logs Part of OpenTelemetry logs Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants