Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Logs Bridge API #4798

Closed
wants to merge 5 commits into from
Closed

Conversation

pellared
Copy link
Member

@pellared pellared commented Dec 27, 2023

Fixes #3827

Based on #4725

Related to #4696

Benchmark results (all allocations are caused by usage of strconv functions):

$ go test -run=^$ -bench=.
goos: linux
goarch: amd64
pkg: go.opentelemetry.io/otel/log/internal
cpu: Intel(R) Core(TM) i9-10885H CPU @ 2.40GHz
BenchmarkEmit/noop/no_attrs-16          450815065                2.617 ns/op           0 B/op          0 allocs/op
BenchmarkEmit/noop/3_attrs-16           75480518                15.22 ns/op            0 B/op          0 allocs/op
BenchmarkEmit/noop/5_attrs-16           58495515                20.10 ns/op            0 B/op          0 allocs/op
BenchmarkEmit/noop/10_attrs-16          39001635                26.68 ns/op            0 B/op          0 allocs/op
BenchmarkEmit/noop/40_attrs-16          12702404                81.41 ns/op            0 B/op          0 allocs/op
BenchmarkEmit/writer/no_attrs-16        15203751                75.06 ns/op           16 B/op          1 allocs/op
BenchmarkEmit/writer/3_attrs-16          5545542               209.2 ns/op            48 B/op          4 allocs/op
BenchmarkEmit/writer/5_attrs-16          4459609               244.9 ns/op            48 B/op          4 allocs/op
BenchmarkEmit/writer/10_attrs-16         2722802               410.5 ns/op            88 B/op          7 allocs/op
BenchmarkEmit/writer/40_attrs-16          779419              1371 ns/op             328 B/op         25 allocs/op
PASS
ok      go.opentelemetry.io/otel/log/internal   12.688s

This PR is to be split into multiple PRs to make reviewing more effective:

  1. design doc: log: Add design doc #4809
  2. source code and unit tests (update DESIGN.md to reference the source files)
  3. package comments
  4. benchmarks (update DESIGN.md to reference the benchmark test file)

Copy link

codecov bot commented Dec 27, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (259143a) 82.3% compared to head (639b395) 82.3%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #4798   +/-   ##
=====================================
  Coverage   82.3%   82.3%           
=====================================
  Files        226     228    +2     
  Lines      18401   18466   +65     
=====================================
+ Hits       15148   15211   +63     
- Misses      2969    2971    +2     
  Partials     284     284           
Files Coverage Δ
log/provider.go 100.0% <100.0%> (ø)
log/internal/writer_logger.go 94.4% <94.4%> (ø)

@pellared pellared force-pushed the bridge-api branch 2 times, most recently from 7f50ed8 to ad7b2fe Compare December 27, 2023 13:52
@pellared pellared changed the title [WIP] Logs Bridge API Logs Bridge API Dec 27, 2023
@pellared pellared marked this pull request as ready for review December 27, 2023 14:03
@pellared pellared force-pushed the bridge-api branch 4 times, most recently from ed4d49e to f6065fa Compare December 28, 2023 16:30
Bump github.com/go-git/go-git/v5 from 5.9.0 to 5.11.0 in /internal/tools (open-telemetry#4800)

Bumps [github.com/go-git/go-git/v5](https://github.com/go-git/go-git) from 5.9.0 to 5.11.0.
- [Release notes](https://github.com/go-git/go-git/releases)
- [Commits](go-git/go-git@v5.9.0...v5.11.0)

---
updated-dependencies:
- dependency-name: github.com/go-git/go-git/v5
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Little refinements
@pellared pellared changed the title Logs Bridge API [Reference] Logs Bridge API Jan 2, 2024
@pellared pellared marked this pull request as draft January 2, 2024 17:29
@pellared pellared mentioned this pull request Jan 2, 2024
@pellared pellared changed the title [Reference] Logs Bridge API [WIP] Logs Bridge API Jan 10, 2024
@pellared pellared closed this Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Logs Bridge API
1 participant