Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

baggage: Fix Parse to validate member value before percent-decoding #4755

Merged
merged 4 commits into from
Dec 19, 2023

Conversation

pellared
Copy link
Member

Fixes #4241

CC @Lim3nius

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Merging #4755 (2b28cee) into main (15f0ab9) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #4755   +/-   ##
=====================================
  Coverage   82.2%   82.2%           
=====================================
  Files        225     225           
  Lines      18319   18315    -4     
=====================================
- Hits       15059   15058    -1     
+ Misses      2977    2975    -2     
+ Partials     283     282    -1     
Files Coverage Δ
baggage/baggage.go 100.0% <100.0%> (+0.7%) ⬆️

Copy link

@Lim3nius Lim3nius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@pellared pellared merged commit 43bd47d into open-telemetry:main Dec 19, 2023
25 checks passed
@MrAlias MrAlias added this to the v1.22.0 milestone Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

baggage module fails to accept baggage produced by itself
5 participants