Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use url.PathUnescape rather than url.QueryUnescape in baggage parsing #4667

Merged
merged 8 commits into from
Oct 31, 2023
Merged

Use url.PathUnescape rather than url.QueryUnescape in baggage parsing #4667

merged 8 commits into from
Oct 31, 2023

Commits on Oct 24, 2023

  1. Use url.PathUnescape rather than url.QueryUnescape 

    I believe this addresses the majority of the cases described in
open-telemetry#3601

Golang's url.QueryUnescape will render url _path_ elements (e.g. /, +)
as spaces: `foo+bar` is rendered as `foo bar`.  Path elements are (as I
read the spec) legal W3C baggage values, and replacing them with spaces
fails the value validation regex.

url.PathEscape allows path elements through unmolested.

Signed-off-by: Nathan J. Mehl <n@oden.io>
    @n-oden
    n-oden committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    f22a4f2 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2023

  1. Merge branch 'main' into main

    @n-oden
    n-oden committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    9aad30c View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2023

  1. Update CHANGELOG.md 

    address comments

Co-authored-by: Robert Pająk <pellared@hotmail.com>
    @n-oden @pellared
    n-oden and pellared committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    6f203db View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into main

    @n-oden
    n-oden committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    0efc2bc View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into main

    @n-oden
    n-oden committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    aab183d View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2023

  1. Merge branch 'main' into main

    @n-oden
    n-oden committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    fb46309 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into main

    @n-oden
    n-oden committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    4110835 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2023

  1. Merge branch 'main' into main

    @n-oden
    n-oden committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    59af688 View commit details
    Browse the repository at this point in the history