Bump default Go version to 1.19 #3694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
added
pkg:tooling
MrAlias
requested review from
jmacd,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
dashpole
approved these changes
Feb 7, 2023
Aneurysm9
approved these changes
Feb 7, 2023
pellared
approved these changes
Feb 8, 2023
yurishkuro
approved these changes
Feb 8, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3694 +/- ##
=======================================
- Coverage 79.7% 79.7% -0.1%
=======================================
Files 171 171
Lines 12673 12673
=======================================
- Hits 10105 10101 -4
- Misses 2355 2359 +4
Partials 213 213
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest golangci-lint version requires Go >= 1.19: #3690
We are adding support for Go 1.20 in #3693, this preemptively bumps the minimum version support of the default Go prior to dropping Go 1.18 after the next release. We already have done this in contrib as it is needed for CI compatibility there as well.