New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Extrema type for Histogram min/max #3550
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
added
pkg:SDK
Related to an SDK package
area:metrics
Part of OpenTelemetry Metrics
labels
Dec 19, 2022
MrAlias
changed the title
Use Extrema type for Histogram min/max
PoC: Use Extrema type for Histogram min/max
Dec 19, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3550 +/- ##
=====================================
Coverage 79.4% 79.4%
=====================================
Files 170 170
Lines 12628 12645 +17
=====================================
+ Hits 10030 10047 +17
Misses 2388 2388
Partials 210 210
|
jmacd
reviewed
Jan 3, 2023
We should add benchmarks here to show qualitative values of different proposals. |
https://gist.github.com/MrAlias/fefe010bbee8671e65d4540af44911f5 |
MrAlias
changed the title
PoC: Use Extrema type for Histogram min/max
Use Extrema type for Histogram min/max
Jan 13, 2023
MrAlias
requested review from
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
January 13, 2023 00:45
MadVikingGod
approved these changes
Jan 23, 2023
Aneurysm9
reviewed
Jan 25, 2023
dashpole
approved these changes
Jan 26, 2023
Aneurysm9
approved these changes
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #3201
Prevent two allocations for every
HistogramDataPoint
that is created by replacing theMin
andMax
pointer fields with a newExtrema
type. Meaning, thisbecomes
with
Extrema
declared as:See this gist for a comparison of the performance among the approaches proposed in #3201.