Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace view use from sdk/metric/view to sdk/metric #3461

Merged
merged 25 commits into from Nov 19, 2022

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Nov 12, 2022

Blocked by #3459

Step 2 of 4 from #3399

@MrAlias MrAlias added pkg:SDK Related to an SDK package area:metrics Part of OpenTelemetry Metrics Skip Changelog PRs that do not require a CHANGELOG.md entry labels Nov 12, 2022
@MrAlias MrAlias added this to the Metric v0.34.0 milestone Nov 12, 2022
@codecov
Copy link

codecov bot commented Nov 12, 2022

Codecov Report

Merging #3461 (733cc93) into main (b061809) will decrease coverage by 0.0%.
The diff coverage is 89.8%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #3461     +/-   ##
=======================================
- Coverage   77.9%   77.8%   -0.1%     
=======================================
  Files        165     165             
  Lines      11620   11614      -6     
=======================================
- Hits        9052    9046      -6     
  Misses      2372    2372             
  Partials     196     196             
Impacted Files Coverage Δ
exporters/otlp/otlpmetric/exporter.go 67.2% <0.0%> (ø)
exporters/otlp/otlpmetric/otlpmetricgrpc/client.go 85.7% <0.0%> (ø)
exporters/otlp/otlpmetric/otlpmetrichttp/client.go 76.6% <0.0%> (ø)
sdk/metric/periodic_reader.go 89.4% <50.0%> (ø)
...xporters/otlp/otlpmetric/internal/oconf/options.go 79.8% <100.0%> (ø)
exporters/stdout/stdoutmetric/config.go 72.9% <100.0%> (ø)
exporters/stdout/stdoutmetric/exporter.go 100.0% <100.0%> (ø)
sdk/metric/config.go 94.3% <100.0%> (ø)
sdk/metric/instrument_provider.go 100.0% <100.0%> (ø)
sdk/metric/internal/filter.go 100.0% <100.0%> (ø)
... and 4 more

@MrAlias MrAlias merged commit 037719b into open-telemetry:main Nov 19, 2022
@MrAlias MrAlias deleted the replace-view-use branch November 19, 2022 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:metrics Part of OpenTelemetry Metrics pkg:SDK Related to an SDK package Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants