Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add View, NewView, Instrument, Stream, and InstrumentKind to sdk/metric with unit tests #3459

Merged
merged 19 commits into from Nov 16, 2022
Merged

Add View, NewView, Instrument, Stream, and InstrumentKind to sdk/metric with unit tests #3459

merged 19 commits into from Nov 16, 2022

Commits on Nov 10, 2022

  1. Add the InstrumentKind type and vars to sdk/metric

    @MrAlias
    MrAlias committed Nov 10, 2022
    Copy the full SHA
    5aea817 View commit details
    Browse the repository at this point in the history

  2. Add the Instrument type to sdk/metric

    @MrAlias
    MrAlias committed Nov 10, 2022
    Copy the full SHA
    5b5d7e4 View commit details
    Browse the repository at this point in the history

  3. Add the Stream type to sdk/metric

    @MrAlias
    MrAlias committed Nov 10, 2022
    Copy the full SHA
    80061df View commit details
    Browse the repository at this point in the history

  4. Add the View type to sdk/metric

    @MrAlias
    MrAlias committed Nov 10, 2022
    Copy the full SHA
    c772a39 View commit details
    Browse the repository at this point in the history

  5. Add NewView to create Views matching OTel spec

    @MrAlias
    MrAlias committed Nov 10, 2022
    Copy the full SHA
    791245a View commit details
    Browse the repository at this point in the history

  6. Add unit tests for NewView

    @MrAlias
    MrAlias committed Nov 10, 2022
    Copy the full SHA
    8e591c5 View commit details
    Browse the repository at this point in the history

  7. Add changes to changelog

    @MrAlias
    MrAlias committed Nov 10, 2022
    Copy the full SHA
    dd3512d View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2022

  1. Apply suggestions from code review 

    Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
    @MrAlias @Aneurysm9
    MrAlias and Aneurysm9 committed Nov 11, 2022
    Copy the full SHA
    b33ebaf View commit details
    Browse the repository at this point in the history

  2. Update CHANGELOG.md

    @MrAlias
    MrAlias committed Nov 11, 2022
    Copy the full SHA
    9519abd View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into metric-view

    @MrAlias
    MrAlias committed Nov 11, 2022
    Copy the full SHA
    e2d716c View commit details
    Browse the repository at this point in the history

  4. Update match and mask comments of Instrument

    @MrAlias
    MrAlias committed Nov 11, 2022
    Copy the full SHA
    f7f7d0e View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into metric-view

    @MrAlias
    MrAlias committed Nov 11, 2022
    Copy the full SHA
    25b9636 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into metric-view

    @MrAlias
    MrAlias committed Nov 11, 2022
    Copy the full SHA
    0e46a90 View commit details
    Browse the repository at this point in the history

  7. Explain wildcard logic in NewView with comment

    @MrAlias
    MrAlias committed Nov 11, 2022
    Copy the full SHA
    623525e View commit details
    Browse the repository at this point in the history

  8. Drop views that replace name for multi-inst match

    @MrAlias
    MrAlias committed Nov 11, 2022
    Copy the full SHA
    56ef349 View commit details
    Browse the repository at this point in the history

  9. Comment how users are expected to match zero-vals

    @MrAlias
    MrAlias committed Nov 11, 2022
    Copy the full SHA
    a350588 View commit details
    Browse the repository at this point in the history

  10. Remove InstrumentKind and Scope from Stream

    @MrAlias
    MrAlias committed Nov 11, 2022
    Copy the full SHA
    3bdcf8a View commit details
    Browse the repository at this point in the history

  11. Fix redundant word in NewView comment

    @MrAlias
    MrAlias committed Nov 11, 2022
    Copy the full SHA
    f2c47b9 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2022

  1. Merge branch 'main' into metric-view

    @hanyuancheung
    hanyuancheung committed Nov 14, 2022
    Copy the full SHA
    99e4af1 View commit details
    Browse the repository at this point in the history