Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not handle empty partial OTLP successes #3438

Merged
merged 4 commits into from Nov 3, 2022
Merged

Do not handle empty partial OTLP successes #3438

merged 4 commits into from Nov 3, 2022

Commits on Nov 2, 2022

  1. Do not handle empty partial OTLP successes 

    Fix open-telemetry#3432.

The OTLP server will respond with empty partial success responses (i.e.
empty messages and 0 count). Treat these as equivalent to it not being
set/present like the documentation specifies in the proto:
https://github.com/open-telemetry/opentelemetry-proto/blob/724e427879e3d2bae2edc0218fff06e37b9eb46e/opentelemetry/proto/collector/trace/v1/trace_service.proto#L58
    @MrAlias
    MrAlias committed Nov 2, 2022
    Copy the full SHA
    8df1193 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into fix-3432

    @MrAlias
    MrAlias committed Nov 2, 2022
    Copy the full SHA
    ba814ec View commit details
    Browse the repository at this point in the history

  3. Fix tests

    @MrAlias
    MrAlias committed Nov 2, 2022
    Copy the full SHA
    ca6b224 View commit details
    Browse the repository at this point in the history

  4. Add changes to changelog

    @MrAlias
    MrAlias committed Nov 2, 2022
    Copy the full SHA
    54b3fe3 View commit details
    Browse the repository at this point in the history