Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only registers callbacks if non-drop aggregation is used #3408

Merged
merged 20 commits into from Nov 11, 2022

Commits on Oct 28, 2022

  1. Do not return an error for Drop aggs

    The async instruments currently return an error if and only if there are
    no aggregators returned from a resolve. Returning no aggregators means
    the instrument aggregation is drop. Do not include this in the error
    reporting decision.
    MrAlias committed Oct 28, 2022
    Copy the full SHA
    c236cdc View commit details
    Browse the repository at this point in the history
  2. Only registers callbacks if non-drop agg is used

    The instruments passed to RegisterCallback need to have some aggregation
    defined otherwise it is implied they have a Drop aggregation. Check that
    at least one instrument passed has an aggregation other than Drop before
    registering the callback with the pipelines.
    
    Also, return an error if the user passed another API implementation of
    an asynchronous instrument.
    MrAlias committed Oct 28, 2022
    Copy the full SHA
    e3b28f2 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    9fa997a View commit details
    Browse the repository at this point in the history
  4. Add changes to changelog

    MrAlias committed Oct 28, 2022
    Copy the full SHA
    28f6e99 View commit details
    Browse the repository at this point in the history
  5. Copy the full SHA
    2a997e0 View commit details
    Browse the repository at this point in the history
  6. Copy the full SHA
    ab25a23 View commit details
    Browse the repository at this point in the history
  7. Copy the full SHA
    6bac0bd View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2022

  1. Copy the full SHA
    229ce58 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    deb7b76 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    509a4af View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    7a55a97 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2022

  1. Copy the full SHA
    3fbb5ec View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    f1d3533 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    384f51a View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2022

  1. Copy the full SHA
    1d2c540 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2022

  1. Copy the full SHA
    410157a View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2022

  1. Copy the full SHA
    d57f214 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2022

  1. Copy the full SHA
    5941ad7 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2022

  1. Copy the full SHA
    84d3e4f View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    3b041c5 View commit details
    Browse the repository at this point in the history