Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disables context-as-argument linter #3385

Merged
merged 2 commits into from Nov 3, 2022
Merged

Disables context-as-argument linter #3385

merged 2 commits into from Nov 3, 2022

Conversation

MadVikingGod
Copy link
Contributor

This is currently incompatible with viper v1.13.0. Status for the linter found at golangci/golangci-lint#3280

@MadVikingGod
Disables context-as-argument linter
095a353 
This is currently incompatible with viper v1.13.0. Status for the linter found at
golangci/golangci-lint#3280
MrAlias
MrAlias approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't upgrade golangci-lint to the latest version. Should it?

@MadVikingGod
Copy link
Contributor Author

It doesn't need to. If you upgrade viper to v1.13.0, and have an old golangci it will still fail.

@MadVikingGod MadVikingGod added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Oct 20, 2022
@MrAlias
Copy link
Contributor

MrAlias commented Oct 20, 2022

link to #3372

@MrAlias
Copy link
Contributor

MrAlias commented Nov 1, 2022

This looks like it may not be needed. We upgraded to 1.50.1 of golangci-lint here and it no longer fails to run.

@MadVikingGod
Copy link
Contributor Author

MadVikingGod commented Nov 1, 2022 •
edited

It was pinned in 1.50.1, but we don't have it pinned in go-build-tools. If we upgrade the build tools we will have the same problem.

@MrAlias
Copy link
Contributor

MrAlias commented Nov 1, 2022

It was pinned in 1.50.1, but we don't have it pinned in go-build-tools. If we upgrade the build tools we will have the same problem.

If that's the case and we want to move forward with this can you sync with main so we can get this merged?

@MrAlias MrAlias merged commit 6dccc07 into open-telemetry:main Nov 3, 2022
@MrAlias MrAlias added this to the Release v1.11.2 milestone Dec 6, 2022
@MadVikingGod MadVikingGod deleted the mvg/disable-ctx-as-arg branch February 21, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aneurysm9 Aneurysm9 Aneurysm9 approved these changes

@MrAlias MrAlias MrAlias approved these changes

@hanyuancheung hanyuancheung hanyuancheung approved these changes

@jmacd jmacd Awaiting requested review from jmacd

@evantorrie evantorrie Awaiting requested review from evantorrie evantorrie is a code owner

@XSAM XSAM Awaiting requested review from XSAM XSAM is a code owner

@dashpole dashpole Awaiting requested review from dashpole dashpole is a code owner

@pellared pellared Awaiting requested review from pellared pellared is a code owner

@dmathieu dmathieu Awaiting requested review from dmathieu dmathieu is a code owner

Assignees
No one assigned
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
Release v1.11.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MadVikingGod @MrAlias @Aneurysm9 @hanyuancheung