Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove comparability requirement for Readers #3290

Closed
wants to merge 14 commits into from

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Oct 14, 2022

Fix #3085

Instead of tracking the Reader to []view.View pair with a map, create a dedicated viewer type for this. This removes the requirement that Readers are comparable so they can act as a map key.

@codecov
Copy link

codecov bot commented Oct 14, 2022

Codecov Report

Merging #3290 (bc20c7c) into main (ccbc38e) will increase coverage by 0.0%.
The diff coverage is 100.0%.

❗ Current head bc20c7c differs from pull request most recent head 7f685bf. Consider uploading reports for the commit 7f685bf to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #3290   +/-   ##
=====================================
  Coverage   77.9%   77.9%           
=====================================
  Files        164     164           
  Lines      11323   11316    -7     
=====================================
- Hits        8822    8818    -4     
+ Misses      2303    2301    -2     
+ Partials     198     197    -1     
Impacted Files Coverage Δ
sdk/metric/config.go 100.0% <100.0%> (ø)
sdk/metric/pipeline.go 94.5% <100.0%> (+1.0%) ⬆️
sdk/metric/provider.go 100.0% <100.0%> (ø)

@MrAlias MrAlias added pkg:SDK Related to an SDK package area:metrics Part of OpenTelemetry Metrics labels Oct 14, 2022
@MrAlias MrAlias added this to the Metric SDK: Beta milestone Oct 14, 2022
@MrAlias MrAlias removed this from the Metric SDK: Beta milestone Oct 20, 2022
@MrAlias
Copy link
Contributor Author

MrAlias commented Oct 21, 2022

Superseded by #3387

@MrAlias MrAlias closed this Oct 21, 2022
@MrAlias MrAlias deleted the viewers branch October 21, 2022 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:metrics Part of OpenTelemetry Metrics pkg:SDK Related to an SDK package
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Should the SDK API constrain the Readers that can be used?
4 participants