Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #3281: promtheus exporter will cumulatively sum hist buckets #3282

Merged
merged 1 commit into from Oct 14, 2022
Merged

fix #3281: promtheus exporter will cumulatively sum hist buckets #3282

merged 1 commit into from Oct 14, 2022

Conversation

albertlockett
Copy link
Contributor

fixes #3281

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 13, 2022 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: albertlockett / name: Albert (4106fd9)

@albertlockett albertlockett mentioned this pull request Oct 13, 2022
Closed
Aneurysm9
Aneurysm9 approved these changes Oct 13, 2022
View reviewed changes
Copy link
Member

@Aneurysm9 Aneurysm9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changelog entry.

@codecov
Copy link

codecov bot commented Oct 13, 2022 •
edited

Codecov Report

Merging #3282 (39e78cf) into main (a8b9ddc) will decrease coverage by 0.0%.
The diff coverage is 100.0%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #3282     +/-   ##
=======================================
- Coverage   77.7%   77.7%   -0.1%     
=======================================
  Files        163     163             
  Lines      11227   11238     +11     
=======================================
+ Hits        8730    8737      +7     
- Misses      2299    2303      +4     
  Partials     198     198
Impacted Files Coverage Δ
bridge/opentracing/bridge.go 63.4% <100.0%> (+0.5%) ⬆️
exporters/prometheus/exporter.go 78.9% <100.0%> (+0.3%) ⬆️
sdk/trace/batch_span_processor.go 80.2% <0.0%> (-1.8%) ⬇️

@albertlockett
promtheus exporter will sum hist buckets (open-telemetry#3281)
39e78cf 
Signed-off-by: albertlockett <albert.lockett@gmail.com>
@albertlockett
Copy link
Contributor Author

changelog entry added

@MadVikingGod
Copy link
Contributor

This has overwhelming support and fixes a bug. I am merging it a bit sooner than our standard wait period.

@MadVikingGod MadVikingGod merged commit 1e72af4 into open-telemetry:main Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmathieu dmathieu dmathieu approved these changes

@Aneurysm9 Aneurysm9 Aneurysm9 approved these changes

@dashpole dashpole dashpole approved these changes

@MrAlias MrAlias MrAlias approved these changes

@hanyuancheung hanyuancheung hanyuancheung approved these changes

@jmacd jmacd Awaiting requested review from jmacd

@evantorrie evantorrie Awaiting requested review from evantorrie evantorrie is a code owner

@XSAM XSAM Awaiting requested review from XSAM XSAM is a code owner

@MadVikingGod MadVikingGod Awaiting requested review from MadVikingGod MadVikingGod is a code owner

@pellared pellared Awaiting requested review from pellared pellared is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prometheus exporter does not cumulatively sum histogram buckets
7 participants
@albertlockett @MadVikingGod @dmathieu @Aneurysm9 @dashpole @MrAlias @hanyuancheung