Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace meterRegistry with cache #3255

Merged
merged 3 commits into from Oct 12, 2022
Merged

Replace meterRegistry with cache #3255

merged 3 commits into from Oct 12, 2022

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Oct 3, 2022 •
edited

Replaces the meterRegistry with use of the newly added cache type. Thereby removing redundant functionality between different types and reducing the complexity of the code.

Part of #3245

@MrAlias MrAlias added pkg:SDK Related to an SDK package area:metrics Part of OpenTelemetry Metrics Skip Changelog PRs that do not require a CHANGELOG.md entry labels Oct 3, 2022
@MrAlias MrAlias added this to the Metric SDK: Beta milestone Oct 3, 2022
@codecov
Copy link

codecov bot commented Oct 3, 2022 •
edited

Codecov Report

Merging #3255 (a9de847) into main (ff18552) will decrease coverage by 0.0%.
The diff coverage is 100.0%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #3255     +/-   ##
=======================================
- Coverage   77.6%   77.6%   -0.1%     
=======================================
  Files        161     161             
  Lines      11280   11260     -20     
=======================================
- Hits        8763    8743     -20     
  Misses      2317    2317             
  Partials     200     200
Impacted Files Coverage Δ
sdk/metric/meter.go 100.0% <ø> (ø)
sdk/metric/provider.go 100.0% <100.0%> (ø)

@MrAlias MrAlias mentioned this pull request Oct 10, 2022
Merged
@MrAlias MrAlias marked this pull request as ready for review October 11, 2022 20:16
@MrAlias MrAlias mentioned this pull request Oct 12, 2022
Closed
5 tasks
@MrAlias MrAlias merged commit 4a3adaa into open-telemetry:main Oct 12, 2022
@MrAlias MrAlias deleted the meter-cache branch October 12, 2022 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aneurysm9 Aneurysm9 Aneurysm9 approved these changes

@dashpole dashpole dashpole approved these changes

@jmacd jmacd Awaiting requested review from jmacd

@evantorrie evantorrie Awaiting requested review from evantorrie evantorrie is a code owner

@XSAM XSAM Awaiting requested review from XSAM XSAM is a code owner

@MadVikingGod MadVikingGod Awaiting requested review from MadVikingGod MadVikingGod is a code owner

@pellared pellared Awaiting requested review from pellared pellared is a code owner

@hanyuancheung hanyuancheung Awaiting requested review from hanyuancheung hanyuancheung is a code owner

@dmathieu dmathieu Awaiting requested review from dmathieu dmathieu is a code owner

Assignees
No one assigned
Labels
area:metrics Part of OpenTelemetry Metrics pkg:SDK Related to an SDK package Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
Metric v0.33.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MrAlias @Aneurysm9 @dashpole