Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the unused Resource field from the MeterProvider #3253

Merged
merged 2 commits into from Oct 3, 2022
Merged

Remove the unused Resource field from the MeterProvider #3253

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd4827f
Remove the unused Resource field from the MeterProvider
MrAlias Oct 2, 2022
5125880
Merge branch 'main' into rm-res-provider
MrAlias Oct 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 0 additions & 5 deletions sdk/metric/provider.go
View file
Open in desktop
Expand Up @@ -19,16 +19,13 @@ import (

"go.opentelemetry.io/otel/metric"
"go.opentelemetry.io/otel/sdk/instrumentation"
"go.opentelemetry.io/otel/sdk/resource"
)

// MeterProvider handles the creation and coordination of Meters. All Meters
// created by a MeterProvider will be associated with the same Resource, have
// the same Views applied to them, and have their produced metric telemetry
// passed to the configured Readers.
type MeterProvider struct {
res *resource.Resource

meters meterRegistry

forceFlush, shutdown func(context.Context) error
Expand All @@ -51,8 +48,6 @@ func NewMeterProvider(options ...Option) *MeterProvider {
registry := newPipelines(conf.res, conf.readers)

return &MeterProvider{
res: conf.res,

meters: meterRegistry{
pipes: registry,
},
Expand Down