Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle duplicate Aggregators and log instrument conflicts #3251

Merged
merged 29 commits into from Oct 11, 2022
Merged

Handle duplicate Aggregators and log instrument conflicts #3251

merged 29 commits into from Oct 11, 2022

Commits on Sep 29, 2022

  1. Add the cache type

    @MrAlias
    MrAlias committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    bc44d82 View commit details
    Browse the repository at this point in the history

  2. Add cache unit tests

    @MrAlias
    MrAlias committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    29ea02d View commit details
    Browse the repository at this point in the history

  3. Test cache concurrency

    @MrAlias
    MrAlias committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    87324d8 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2022

  1. Add the instrumentCache

    @MrAlias
    MrAlias committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    010b999 View commit details
    Browse the repository at this point in the history

  2. Use the instrumentCache to deduplicate creation

    @MrAlias
    MrAlias committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    8889f32 View commit details
    Browse the repository at this point in the history

  3. Drop unique check from addAggregator

    @MrAlias
    MrAlias committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    40ae7fa View commit details
    Browse the repository at this point in the history

  4. Fix aggregatorCache* docs

    @MrAlias
    MrAlias committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    c7d8d2f View commit details
    Browse the repository at this point in the history

  5. Update cachedAggregator and aggregator method docs

    @MrAlias
    MrAlias committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    45ac559 View commit details
    Browse the repository at this point in the history

  6. Remove unnecessary type constraint

    @MrAlias
    MrAlias committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    d0acf9b View commit details
    Browse the repository at this point in the history

  7. Remove unused errAlreadyRegistered

    @MrAlias
    MrAlias committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    0cec45a View commit details
    Browse the repository at this point in the history

  8. Rename to not shadow imports

    @MrAlias
    MrAlias committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    cae41cc View commit details
    Browse the repository at this point in the history

  9. Add changes to changelog

    @MrAlias
    MrAlias committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    1514d9d View commit details
    Browse the repository at this point in the history

  10. Fix changelog English

    @MrAlias
    MrAlias committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    52e6508 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2022

  1. Merge branch 'main' into agg-cache

    @MrAlias
    MrAlias committed Oct 2, 2022
    Configuration menu
    Copy the full SHA
    668d5d8 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2022

  1. Merge branch 'main' into agg-cache

    @MrAlias
    MrAlias committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    ab1ee04 View commit details
    Browse the repository at this point in the history

  2. Store resolvers in the meter instead of caches

    @MrAlias
    MrAlias committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    c41328c View commit details
    Browse the repository at this point in the history

  3. Test all Aggregator[N] impls are comparable

    @MrAlias
    MrAlias committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    1f83658 View commit details
    Browse the repository at this point in the history

  4. Fix lint

    @MrAlias
    MrAlias committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    71c19e6 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2022

  1. Add documentation that Aggregators need to be comparable

    @MrAlias
    MrAlias committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    2bb7517 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into agg-cache

    @MrAlias
    MrAlias committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    edaf70a View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into agg-cache

    @MrAlias
    MrAlias committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    a453ab7 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2022

  1. Update sdk/metric/internal/aggregator.go 

    Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
    @MrAlias @Aneurysm9
    MrAlias and Aneurysm9 committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    cc91e8a View commit details
    Browse the repository at this point in the history

  2. Update sdk/metric/instrument.go 

    Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
    @MrAlias @Aneurysm9
    MrAlias and Aneurysm9 committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    5832c56 View commit details
    Browse the repository at this point in the history

  3. Update sdk/metric/instrument.go 

    Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
    @MrAlias @Aneurysm9
    MrAlias and Aneurysm9 committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    7096a68 View commit details
    Browse the repository at this point in the history

  4. Update sdk/metric/internal/aggregator_test.go 

    Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
    @MrAlias @Aneurysm9
    MrAlias and Aneurysm9 committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    32f47bf View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into agg-cache

    @MrAlias
    MrAlias committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    d90819f View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2022

  1. Merge branch 'main' into agg-cache

    @MrAlias
    MrAlias committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    8b0ac23 View commit details
    Browse the repository at this point in the history

  2. Fix pipeline_test.go use of newInstrumentCache

    @MrAlias
    MrAlias committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    b876373 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into agg-cache

    @MrAlias
    MrAlias committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    b913d7a View commit details
    Browse the repository at this point in the history