New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix duplicate instrument registration to return same instrument #3238
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3238 +/- ##
=======================================
+ Coverage 77.3% 77.4% +0.1%
=======================================
Files 159 160 +1
Lines 11184 11228 +44
=======================================
+ Hits 8651 8699 +48
+ Misses 2335 2331 -4
Partials 198 198
|
This does not resolve #3240. I'm looking into how feasible it would be to resolve that as well here, but its resolution might need to be a follow-on PR. |
It does look like we can cache lower in the computation processing to handle #3240: MrAlias#661. I'm going to close this so it is not reviewed, and refactor a more complete solution for another PR. |
Add a new
cache
type to handle generic lookup functionality. Wrap this new type in an newinstrumentCache
to be used by theresolver
when resolvingAggregators
. If an instrument has already been resolved, it returns those aggregations or an error.The new
cache
type is defined generically so its can be unified with themeterRegistry
, which duplicates the functionality. That unification is left to a follow-on PR.