Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Refactor Duplicated Code of OTLP Exporter #3189

Conversation

hanyuancheung
Copy link
Member

Fix: part of #2641

  • Refactor otlpconfig part from exporter/otlp/otlpmetric(otlptrace)/internal/ into exporter/otlp/internal/envconfig

@codecov
Copy link

codecov bot commented Sep 18, 2022

Codecov Report

Merging #3189 (0d232df) into main (8c6e6c4) will decrease coverage by 0.0%.
The diff coverage is 90.9%.

❗ Current head 0d232df differs from pull request most recent head cc62a02. Consider uploading reports for the commit cc62a02 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #3189     +/-   ##
=======================================
- Coverage   77.3%   77.3%   -0.1%     
=======================================
  Files        159     154      -5     
  Lines      11134   10984    -150     
=======================================
- Hits        8610    8494    -116     
+ Misses      2327    2297     -30     
+ Partials     197     193      -4     
Impacted Files Coverage Δ
exporters/otlp/internal/envconfig/config.go 100.0% <ø> (ø)
...orters/otlp/otlpmetric/internal/otest/collector.go 7.2% <0.0%> (ø)
exporters/otlp/otlpmetric/otlpmetricgrpc/config.go 35.2% <47.3%> (ø)
exporters/otlp/otlptrace/otlptracegrpc/options.go 76.4% <78.9%> (ø)
exporters/otlp/internal/envconfig/options.go 81.7% <86.0%> (ø)
exporters/otlp/internal/envconfig/envconfig.go 98.3% <100.0%> (+2.7%) ⬆️
exporters/otlp/otlpmetric/otlpmetricgrpc/client.go 87.8% <100.0%> (ø)
exporters/otlp/otlpmetric/otlpmetrichttp/client.go 78.8% <100.0%> (ø)
exporters/otlp/otlpmetric/otlpmetrichttp/config.go 100.0% <100.0%> (ø)
exporters/otlp/otlptrace/otlptracegrpc/client.go 92.5% <100.0%> (ø)
... and 7 more

@hanyuancheung hanyuancheung force-pushed the feature/refactor-duplicated-code-otlp-exporter branch from 501f074 to 4db2f53 Compare September 20, 2022 15:03
@hanyuancheung hanyuancheung force-pushed the feature/refactor-duplicated-code-otlp-exporter branch from 0d232df to e9e0e59 Compare September 23, 2022 11:42
@hanyuancheung hanyuancheung force-pushed the feature/refactor-duplicated-code-otlp-exporter branch 2 times, most recently from a5bda8c to b24cef0 Compare September 23, 2022 12:00
@MrAlias
Copy link
Contributor

MrAlias commented Sep 14, 2023

Closing, the duplicate files are not generated.

@MrAlias MrAlias closed this Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants