Proof-of-Concept for partial export err returns #3153
Conversation
| @@ -45,3 +48,14 @@ type SpanExporter interface { | |||
| // DO NOT CHANGE: any modification will not be backwards compatible and | |||
| // must never be done outside of a new major release. | |||
| } | |||
|
|
|||
| type PartialExportError struct { | |||
There was a problem hiding this comment.
How is this different from having the error in otlp or otlptrace? Yes other exporters can theoretically create this error, but no other exporter has this kind of error.
There was a problem hiding this comment.
Discussed in SIG meeting, but for others interested: There are likely other exporters that support partial successes. For instance, there is the sumologic exporter in the collector.
| // Wrap returns a wrapped version of the downstream SpanExporter with | ||
| // telemetry flow reporting. All calls to the returned SpanProcessor will | ||
| // introspected for telemetry data and then forwarded to downstream. | ||
| func Wrap(downstream SpanExporter, options ...Option) SpanProcessor { |
There was a problem hiding this comment.
Would you want to return a SpanExporter here? That way you can still use the batch processor, and you would just be instrumenting the calls to around ExportSpans()
There was a problem hiding this comment.
Yeah, that could makes sense. This was (quickly) adapted from the flow SpanProcessor, which exports metrics about started/stopped spans. I can definitely see another package where this is a simple wrapper of a SpanExporter and only reports dropped values.
|
Closing as this is not meant to be merged and has been included in the discussion. |
Not submitted for review. Part of discussion in #3146.