golangci-lint not working correctly #2987
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Petrie
requested review from
jmacd,
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
Aneurysm9
reviewed
Jun 29, 2022
| @@ -76,7 +76,7 @@ func TestLastValueUpdate(t *testing.T) { | |||
|
|
|||
| var last number.Number | |||
| for i := 0; i < count; i++ { | |||
| x := profile.Random(rand.Intn(1)*2 - 1) | |||
| x := profile.Random(rand.Intn(2)*2 - 1) | |||
There was a problem hiding this comment.
This doesn't feel right. What's the lint error being raised here and why is this the approach taken to fix it?
There was a problem hiding this comment.
The lint error is
aggregator/lastvalue/lastvalue_test.go:79:24: SA4030: math/rand.Intn(n) generates a random value 0 <= x < n; that is, the generated values don't include n; rand.Intn(1) therefore always returns 0 (staticcheck)
x := profile.Random(rand.Intn(1)*2 - 1)
^As my first comment says , As a freshman for metric, I'm not sure this changes is correctly. pls make some advice directly.
Codecov Report
@@ Coverage Diff @@
## main #2987 +/- ##
=====================================
Coverage 75.7% 75.7%
=====================================
Files 177 177
Lines 11813 11813
=====================================
+ Hits 8943 8945 +2
+ Misses 2636 2634 -2
Partials 234 234
|
This was referenced Jun 30, 2022
Closed
|
|
|
This looks to have been resolve a while ago as far as I can tell. We are currently at version 1.50.1 of golangci-lint: #3404 Closing as this looks superseded. Please reopen if this was in error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's two main changes
go.mod. because dependabot is not able to update non-semver dependency.golangci-lintversion to fix some linters not working correctly. Some linters not working correctly on versionv1.45.3-0.20220330010013-d2ccc6d2bbbb, I don't why, but after upgrade, it works.Additionally
As a freshman for metric, i'm not sure this changes is correctly for fix linter on
sdk/metric/aggregator/lastvalue/lastvalue_test.go:79Related link:
blizzy78/varnamelen#13 (comment)
#2761