Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a bug in example/fib/app.go line:69 #2860

Merged
merged 5 commits into from Apr 26, 2022
Merged

Fix a bug in example/fib/app.go line:69 #2860

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fd321e2
modify the Fscanf function param in example/fib/app.go line:69 to avo…
Frapschen Apr 25, 2022
9ce4f60
Add pull reqesut ID into CHANGELOG.md
Frapschen Apr 25, 2022
1687543
append "\n" to the string param of Fscanf() in getting-started.md
Frapschen Apr 25, 2022
809153c
delete a line in CHANGELOG.md.
Frapschen Apr 25, 2022
dae5dec
Merge branch 'main' into fix_a__bug_in_example/fib/app.go
MrAlias Apr 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion example/fib/app.go
View file
Open in desktop
Expand Up @@ -66,7 +66,7 @@ func (a *App) Poll(ctx context.Context) (uint, error) {
a.l.Print("What Fibonacci number would you like to know: ")

var n uint
_, err := fmt.Fscanf(a.r, "%d", &n)
_, err := fmt.Fscanf(a.r, "%d\n", &n)
if err != nil {
span.RecordError(err)
span.SetStatus(codes.Error, err.Error())
Expand Down
4 changes: 2 additions & 2 deletions website_docs/getting-started.md
View file
Open in desktop
Expand Up @@ -214,7 +214,7 @@ func (a *App) Poll(ctx context.Context) (uint, error) {
a.l.Print("What Fibonacci number would you like to know: ")

var n uint
_, err := fmt.Fscanf(a.r, "%d", &n)
_, err := fmt.Fscanf(a.r, "%d\n", &n)

// Store n as a string to not overflow an int64.
nStr := strconv.FormatUint(uint64(n), 10)
Expand Down Expand Up @@ -458,7 +458,7 @@ func (a *App) Poll(ctx context.Context) (uint, error) {
a.l.Print("What Fibonacci number would you like to know: ")

var n uint
_, err := fmt.Fscanf(a.r, "%d", &n)
_, err := fmt.Fscanf(a.r, "%d\n", &n)
if err != nil {
span.RecordError(err)
span.SetStatus(codes.Error, err.Error())
Expand Down