Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

silence tlsCert.RootCAs.Subjects is deprecated lint err #2674

Merged
merged 4 commits into from Mar 16, 2022
Merged

silence tlsCert.RootCAs.Subjects is deprecated lint err #2674

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
09fad16
silence tlsCert.RootCAs.Subjects is deprecated lint err
sourikghosh Mar 14, 2022
0d8ed8a
silence rest of the occurrence
sourikghosh Mar 15, 2022
50bd809
Merge branch 'main' into fix/lint-issue
MadVikingGod Mar 16, 2022
53876f4
Merge branch 'main' into fix/lint-issue
MrAlias Mar 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions exporters/otlp/internal/envconfig/envconfig_test.go
View file
Open in desktop
Expand Up @@ -288,6 +288,8 @@ func TestWithTLSConfig(t *testing.T) {
WithTLSConfig("CERTIFICATE", func(v *tls.Config) {
option = testOption{TestTLS: v}
}))

// nolint:staticcheck // ignoring tlsCert.RootCAs.Subjects is deprecated ERR because cert does not come from SystemCertPool.
assert.Equal(t, tlsCert.RootCAs.Subjects(), option.TestTLS.RootCAs.Subjects())
}

Expand Down