Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependabot-generate make target #2613

Merged
merged 9 commits into from
Feb 17, 2022
Merged

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Feb 15, 2022

Fix #2612

  • A new dependabot-generate target is added to automatically and reproducible generate the dependabot configuration. This is added as a way to easy fixing the error generated by dependabot-check. This target is added to the precommit target dependencies.
  • A dedicated dbotconf utility is added to generate the dependabot configuration.
  • The common code used between crosslink and dbotconf is refactored into the tools package.
  • The dependabot configuration is updated to be generated with this new target.

@MrAlias MrAlias added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Feb 15, 2022
MrAlias added a commit to MrAlias/opentelemetry-go that referenced this pull request Feb 15, 2022
MrAlias added a commit that referenced this pull request Feb 15, 2022
* Refactor Makefile

* Update dependabot targets

* Sync github actions config with Makefile ci target

* Update test targets

* Use sed instead of parameter indexing

* Remove dependabot-generate

Address in #2613 instead.
@MrAlias MrAlias changed the title Refactor dependabot-generate make target into dedicated tool Add dependabot-generate make target Feb 15, 2022
@MrAlias MrAlias marked this pull request as ready for review February 15, 2022 22:10
@codecov
Copy link

codecov bot commented Feb 16, 2022

Codecov Report

Merging #2613 (631f24a) into main (67f508b) will increase coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2613   +/-   ##
=====================================
  Coverage   76.1%   76.2%           
=====================================
  Files        173     173           
  Lines      12234   12234           
=====================================
+ Hits        9320    9327    +7     
+ Misses      2671    2666    -5     
+ Partials     243     241    -2     
Impacted Files Coverage Δ
exporters/jaeger/jaeger.go 92.6% <0.0%> (-0.9%) ⬇️
sdk/trace/batch_span_processor.go 81.1% <0.0%> (+0.9%) ⬆️
sdk/metric/sdk.go 81.5% <0.0%> (+1.4%) ⬆️
sdk/metric/refcount_mapped.go 100.0% <0.0%> (+20.0%) ⬆️

@dmathieu
Copy link
Member

How about a check that would fail if an auto-generated file becomes out of sync from the generator?
(it may be better as a separated PR)

@pellared
Copy link
Member

How about a check that would fail if an auto-generated file becomes out of sync from the generator? (it may be better as a separated PR)

I agree. It should be enough to add dependabot-generate as a dependency to the ci target. The check-clean-work-tree target should catch if any file gets modified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor dependabot-generate make target into dedicated tool
5 participants