Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use Key's Defined method #2593

Merged
merged 3 commits into from Feb 11, 2022
Merged

refactor: use Key's Defined method #2593

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
603d396
optimize(attribute): use Key's Defined method
1046102779 Feb 9, 2022
e3b45c5
Update kv.go
1046102779 Feb 9, 2022
eb8e591
Merge branch 'main' into patch-2
1046102779 Feb 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion attribute/kv.go
View file
Open in desktop
Expand Up @@ -26,7 +26,7 @@ type KeyValue struct {

// Valid returns if kv is a valid OpenTelemetry attribute.
func (kv KeyValue) Valid() bool {
return kv.Key != "" && kv.Value.Type() != INVALID
return kv.Key.Defined() && kv.Value.Type() != INVALID
}

// Bool creates a KeyValue with a BOOL Value type.
Expand Down