Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace recordingSpan attributes implementation with slice of attributes #2576

Merged
merged 15 commits into from Feb 7, 2022
Merged

Replace recordingSpan attributes implementation with slice of attributes #2576

merged 15 commits into from Feb 7, 2022

Commits on Feb 1, 2022

  1. Replace recordingSpan attributes implementation 

    Instead of an LRU strategy for cap-ing span attributes, comply with the
specification and drop last added. To do this, the attributesmap is
replaced with a slice of attributes.
    @MrAlias
    MrAlias committed Feb 1, 2022
    Copy the full SHA
    0acc1bc View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2022

  1. Merge branch 'main' into recordingSpan-attrs-slice

    @MrAlias
    MrAlias committed Feb 2, 2022
    Copy the full SHA
    af790b4 View commit details
    Browse the repository at this point in the history

  2. Remove attributesmap files

    @MrAlias
    MrAlias committed Feb 2, 2022
    Copy the full SHA
    cb4d0e3 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2022

  1. Refine addition algorithm 

    Unify duplicated code.

Fix deduplication algorithm.

Fix droppedAttributes to always be returned, even if the span has no
attributes.
    @MrAlias
    MrAlias committed Feb 3, 2022
    Copy the full SHA
    6952bc5 View commit details
    Browse the repository at this point in the history

  2. Unify span SetAttributes tests

    @MrAlias
    MrAlias committed Feb 3, 2022
    Copy the full SHA
    44ff00b View commit details
    Browse the repository at this point in the history

  3. Doc fix to attr drop order in changelog

    @MrAlias
    MrAlias committed Feb 3, 2022
    Copy the full SHA
    8797c26 View commit details
    Browse the repository at this point in the history

  4. Test span and snapshot attrs

    @MrAlias
    MrAlias committed Feb 3, 2022
    Copy the full SHA
    3c609fa View commit details
    Browse the repository at this point in the history

  5. fix lint

    @MrAlias
    MrAlias committed Feb 3, 2022
    Copy the full SHA
    326b646 View commit details
    Browse the repository at this point in the history

  6. Add tests for recordingSpan method defaults

    @MrAlias
    MrAlias committed Feb 3, 2022
    Copy the full SHA
    b8cff41 View commit details
    Browse the repository at this point in the history

  7. Comment why pre-allocation is not done

    @MrAlias
    MrAlias committed Feb 3, 2022
    Copy the full SHA
    c242f79 View commit details
    Browse the repository at this point in the history

  8. Correct grammar in recordingSpan allocation comment

    @MrAlias
    MrAlias committed Feb 3, 2022
    Copy the full SHA
    ad71060 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'main' into recordingSpan-attrs-slice

    @MrAlias
    MrAlias committed Feb 3, 2022
    Copy the full SHA
    bfa93b9 View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2022

  1. Merge branch 'main' into recordingSpan-attrs-slice

    @MrAlias
    MrAlias committed Feb 4, 2022
    Copy the full SHA
    50ac38b View commit details
    Browse the repository at this point in the history

  2. Update sdk/trace/tracer.go 

    Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
    @MrAlias @Aneurysm9
    MrAlias and Aneurysm9 committed Feb 4, 2022
    Copy the full SHA
    3a8e604 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2022

  1. Merge branch 'main' into recordingSpan-attrs-slice

    @MrAlias
    MrAlias committed Feb 7, 2022
    Copy the full SHA
    9ae80f7 View commit details
    Browse the repository at this point in the history