Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test units of histogram instrument kind #2507

Merged
merged 10 commits into from Mar 23, 2022
Merged

Add test units of histogram instrument kind #2507

Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
4fc52be
test: --20220112 fix histogram instrument unit test
Jan 12, 2022
baed062
Merge branch 'main' into develop/test
Jan 13, 2022
5ed3e72
Merge branch 'main' into develop/test
Feb 22, 2022
e0d5e41
Merge branch 'main' into develop/test
hanyuancheung Feb 28, 2022
4efa0e0
Merge branch 'main' into develop/test
hanyuancheung Mar 3, 2022
16cdd84
Merge branch 'main' into develop/test
hanyuancheung Mar 4, 2022
759af3f
Merge branch 'main' into develop/test
Mar 4, 2022
75e6678
Merge branch 'main' into develop/test
hanyuancheung Mar 5, 2022
3151c87
Merge branch 'main' into develop/test
hanyuancheung Mar 19, 2022
7713723
Merge branch 'main' into develop/test
Aneurysm9 Mar 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
56 changes: 53 additions & 3 deletions exporters/otlp/otlpmetric/exporter_test.go
View file
Open in desktop
Expand Up @@ -225,9 +225,9 @@ func TestNoGroupingExport(t *testing.T) {
)
}

func TestHistogramMetricGroupingExport(t *testing.T) {
func TestHistogramInt64MetricGroupingExport(t *testing.T) {
r := record(
"histogram",
"int64-histogram",
sdkapi.HistogramInstrumentKind,
number.Int64Kind,
append(baseKeyValues, cpuKey.Int(1)),
Expand All @@ -240,7 +240,7 @@ func TestHistogramMetricGroupingExport(t *testing.T) {
{
Metrics: []*metricpb.Metric{
{
Name: "histogram",
Name: "int64-histogram",
Data: &metricpb.Metric_Histogram{
Histogram: &metricpb.Histogram{
AggregationTemporality: metricpb.AggregationTemporality_AGGREGATION_TEMPORALITY_CUMULATIVE,
Expand Down Expand Up @@ -275,6 +275,56 @@ func TestHistogramMetricGroupingExport(t *testing.T) {
runMetricExportTests(t, nil, resource.Empty(), []testRecord{r, r}, expected)
}

func TestHistogramFloat64MetricGroupingExport(t *testing.T) {
r := record(
"float64-histogram",
sdkapi.HistogramInstrumentKind,
number.Float64Kind,
append(baseKeyValues, cpuKey.Int(1)),
testLibName,
)
expected := []*metricpb.ResourceMetrics{
{
Resource: nil,
InstrumentationLibraryMetrics: []*metricpb.InstrumentationLibraryMetrics{
{
Metrics: []*metricpb.Metric{
{
Name: "float64-histogram",
Data: &metricpb.Metric_Histogram{
Histogram: &metricpb.Histogram{
AggregationTemporality: metricpb.AggregationTemporality_AGGREGATION_TEMPORALITY_CUMULATIVE,
DataPoints: []*metricpb.HistogramDataPoint{
{
Attributes: cpu1Labels,
StartTimeUnixNano: startTime(),
TimeUnixNano: pointTime(),
Count: 2,
Sum: 11.0,
ExplicitBounds: testHistogramBoundaries,
BucketCounts: []uint64{1, 0, 0, 1},
},
{
Attributes: cpu1Labels,
Count: 2,
Sum: 11.0,
ExplicitBounds: testHistogramBoundaries,
BucketCounts: []uint64{1, 0, 0, 1},
StartTimeUnixNano: startTime(),
TimeUnixNano: pointTime(),
},
},
},
},
},
},
},
},
},
}
runMetricExportTests(t, nil, resource.Empty(), []testRecord{r, r}, expected)
}

func TestCountInt64MetricGroupingExport(t *testing.T) {
r := record(
"int64-count",
Expand Down