Remove Min/Max unused interfaces from the moved code #2454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
MadVikingGod,
MrAlias,
paivagustavo,
pellared and
XSAM
as code owners
bogdandrutu
commented
Dec 14, 2021
Comment on lines
+31
to
+41
| // Deprecated: Will be removed soon. | ||
| type Min interface { | ||
| Aggregation | ||
| Min() (number.Number, error) | ||
| } | ||
|
|
||
| // Deprecated: use module "go.opentelemetry.io/otel/sdk/metric/export/aggregation" | ||
| type Max = aggregation.Max | ||
| // Deprecated: Will be removed soon. | ||
| type Max interface { | ||
| Aggregation | ||
| Max() (number.Number, error) | ||
| } |
There was a problem hiding this comment.
I kept them in the deprecated package, but removed them from the new package since they are not used. They will be removed with the whole deprecated package.
bogdandrutu
added
the
Skip Changelog
Codecov Report
@@ Coverage Diff @@
## main #2454 +/- ##
=====================================
Coverage 76.3% 76.3%
=====================================
Files 173 173
Lines 12022 12022
=====================================
+ Hits 9175 9177 +2
+ Misses 2602 2600 -2
Partials 245 245
|
MrAlias
approved these changes
Dec 14, 2021
|
@jmacd please review since this is a leftover after the PR you merged to remove MinMaxSumCount aggregation. |
XSAM
approved these changes
Dec 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #2273
Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com