Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Schema URL support to Resource #1938

Merged
merged 4 commits into from Jun 8, 2021
Merged

Add Schema URL support to Resource #1938

merged 4 commits into from Jun 8, 2021

Commits on Jun 7, 2021

  1. Add Schema URL support to Resource 

    This implements specification requirement:
https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/resource/sdk.md#resource-creation

- Changes `resource.NewWithAttributes` to require a schema URL. The old function
  is still available as `resource.NewSchemaless`. This is a breaking change.
  We want to encourage using schema URL and make it a conscious choice to have a
  resource without schema.

- Merge schema URLs acccording to the spec in resource.Merge.

- Several builtin resource detectors now correctly populate the schema URL.
    @tigrannajaryan
    tigrannajaryan committed Jun 7, 2021
    Copy the full SHA
    6c30e22 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2021

  1. Merge branch 'main' into feature/tigran/resource-schema-url

    @MrAlias
    MrAlias committed Jun 8, 2021
    Copy the full SHA
    8c75723 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into feature/tigran/resource-schema-url

    @MrAlias
    MrAlias committed Jun 8, 2021
    Copy the full SHA
    d369dbd View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into feature/tigran/resource-schema-url

    @MrAlias
    MrAlias committed Jun 8, 2021
    Copy the full SHA
    41f780b View commit details
    Browse the repository at this point in the history